Skip to content

BLD: Fix openpyxl to 2.5.5 #22601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Sep 5, 2018

2.5.5 --> 2.5.6 broke compatibility with pandas Timestamp objects.

Closes #22595.

2.5.5 --> 2.5.6 broke compatibility
with pandas Timestamp objects.

Closes pandas-devgh-22595.
@gfyoung gfyoung added Build Library building on various platforms CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions labels Sep 5, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Sep 5, 2018
@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@a5fe9cf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #22601   +/-   ##
=========================================
  Coverage          ?   92.04%           
=========================================
  Files             ?      169           
  Lines             ?    50787           
  Branches          ?        0           
=========================================
  Hits              ?    46746           
  Misses            ?     4041           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.45% <ø> (?)
#single 42.29% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5fe9cf...8a1614c. Read the comment docs.

@TomAugspurger TomAugspurger merged commit d4e9258 into pandas-dev:master Sep 5, 2018
@TomAugspurger
Copy link
Contributor

Thanks!

rhysparry added a commit to rhysparry/pandas that referenced this pull request Sep 5, 2018
* master:
  DOC: Update link and description of the Spyder IDE in Ecosystem docs (pandas-dev#22136)
  BUG: resample with TimedeltaIndex, fenceposts are off (pandas-dev#22488)
  Use dispatch_to_series where possible (pandas-dev#22572)
  BLD: Fix openpyxl to 2.5.5 (pandas-dev#22601)
@gfyoung gfyoung deleted the openpyxl-version-break branch September 5, 2018 16:42
gfyoung added a commit to forking-repos/pandas that referenced this pull request Sep 8, 2018
gfyoung added a commit to forking-repos/pandas that referenced this pull request Sep 8, 2018
gfyoung added a commit to forking-repos/pandas that referenced this pull request Sep 9, 2018
gfyoung added a commit that referenced this pull request Sep 11, 2018
* CI: Bump NumPy to 1.9.3

Backport of gh-22499.

* BLD: Fix openpyxl to 2.5.5

Backport of gh-22601.

* CI: Resolve timeout issue on Travis

Backported from gh-22429.

* CI: Migrate to CircleCI 2.0

Backport of gh-21814.

* Upgrade Cython to >=0.28.2

Backported from gh-21688.

* TST: Patch locale handling

Backported from gh-21739.
Backport of gh-22213.
@@ -14,7 +14,7 @@ lxml
matplotlib
nbsphinx
numexpr
openpyxl
openpyxl=2.5.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required format is openpyxl==2.5.5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raised PR #22749

aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Sep 20, 2018
2.5.5 --> 2.5.6 broke compatibility
with pandas Timestamp objects.

Closes pandas-devgh-22595.
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
2.5.5 --> 2.5.6 broke compatibility
with pandas Timestamp objects.

Closes pandas-devgh-22595.
@alimcmaster1 alimcmaster1 mentioned this pull request Oct 26, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants