-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI / BLD: Various CI Backports #22637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @gfyoung! Thanks for submitting the PR.
|
@jreback @TomAugspurger : Looks like we need to backport a couple of other things:
|
8d57932
to
59c1640
Compare
Codecov Report
@@ Coverage Diff @@
## 0.23.x #22637 +/- ##
==========================================
+ Coverage 91.83% 91.84% +<.01%
==========================================
Files 153 153
Lines 49591 49588 -3
==========================================
- Hits 45544 45543 -1
+ Misses 4047 4045 -2
Continue to review full report at Codecov.
|
Really weird locale failures. Any thoughts? |
Backport of pandas-devgh-22499.
Backport of pandas-devgh-22601.
08623da
to
ccc8bb3
Compare
Backported from pandas-devgh-22429.
ccc8bb3
to
2b28893
Compare
Backport of pandas-devgh-21814.
Backported from pandas-devgh-21688.
9d177db
to
530a21f
Compare
@jreback @TomAugspurger : Tried doing some more investigation, but still not sure where the locale failures are coming from. I would like to potentially merge everything up to 2b28893 first, which would address the failures I was seeing in #22634. |
What's our plan for release? I don't really have a strong desire to do a
0.23.5, especially if it's a pain to backport things.
…On Mon, Sep 10, 2018 at 12:39 AM gfyoung ***@***.***> wrote:
@jreback <https://github.com/jreback> @TomAugspurger
<https://github.com/TomAugspurger> : Tried doing some more investigation,
but still not sure where the locale failures are coming from. I would like
to potentially merge everything up to 2b28893
<2b28893>
first, which would address the failures I was seeing in #22634
<#22634>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22637 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIrjGnYfVS3yec0lAGTtOc-rFCyo7ks5uZfsXgaJpZM4Wf8ja>
.
|
#22213 may be the one to fix locales. |
could pass on 23.5 and just do 24 maybe by end of sept |
@TomAugspurger : The "pain" of backporting has been due to CI changes that in hindsight should have been backported earlier than later. I think we should probably backport changes that:
|
@TomAugspurger : Ah, thanks for pointing that out. Let me see if that solves anything... |
Backported from pandas-devgh-21739. Backport of pandas-devgh-22213.
@jreback @TomAugspurger : Well would you look at that? That seemed to have done the trick! All tests are passing now with Circle 2.0. PTAL. |
LGTM at a glance, thanks. Feel free to merge when you're ready (probably rebase & merge since it's a backport branch). |
@TomAugspurger : This is against the |
blosc
to1.14.3
(Pin blosc to 1.14.3 for travis-27 build #22429)openpyxl
to2.5.5
(BLD: Fix openpyxl to 2.5.5 #22601)numpy
to1.9.3
(CI: Bump to NumPy compat to 1.9.3 #22499)Cython
to>=0.28.2
(Accept constant memoryviews in HashTable.lookup #21688)