Skip to content

CI / BLD: Various CI Backports #22637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2018
Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Sep 8, 2018

@gfyoung gfyoung added Build Library building on various platforms CI Continuous Integration labels Sep 8, 2018
@gfyoung gfyoung added this to the 0.23.5 milestone Sep 8, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@gfyoung
Copy link
Member Author

gfyoung commented Sep 8, 2018

@jreback @TomAugspurger : Looks like we need to backport a couple of other things:

  • numpy version updates (for the lib.gfortran errors)

  • locale fixes!? (for some reason, py35_ascii is picking up way more locales than it does on master, causing all of the failures on that build - there are some slight differences in the implementation of tm.get_locales, so that might be the cause)

@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #22637 into 0.23.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.23.x   #22637      +/-   ##
==========================================
+ Coverage   91.83%   91.84%   +<.01%     
==========================================
  Files         153      153              
  Lines       49591    49588       -3     
==========================================
- Hits        45544    45543       -1     
+ Misses       4047     4045       -2
Flag Coverage Δ
#multiple 90.24% <100%> (ø) ⬆️
#single 41.79% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 84.21% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932de54...c780f95. Read the comment docs.

@gfyoung
Copy link
Member Author

gfyoung commented Sep 9, 2018

@jreback @TomAugspurger :

* https://travis-ci.org/pandas-dev/pandas/jobs/426221423

Build keeps timing out (seems unrelated with PR though).

Really weird locale failures.

Any thoughts?

@gfyoung gfyoung force-pushed the ci-backports branch 2 times, most recently from 08623da to ccc8bb3 Compare September 10, 2018 00:22
@gfyoung
Copy link
Member Author

gfyoung commented Sep 10, 2018

@jreback @TomAugspurger : Tried doing some more investigation, but still not sure where the locale failures are coming from. I would like to potentially merge everything up to 2b28893 first, which would address the failures I was seeing in #22634.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Sep 10, 2018 via email

@TomAugspurger
Copy link
Contributor

#22213 may be the one to fix locales.

@jreback
Copy link
Contributor

jreback commented Sep 10, 2018

could pass on 23.5 and just do 24 maybe by end of sept

@gfyoung
Copy link
Member Author

gfyoung commented Sep 10, 2018

What's our plan for release? I don't really have a strong desire to do a
0.23.5, especially if it's a pain to backport things.

@TomAugspurger : The "pain" of backporting has been due to CI changes that in hindsight should have been backported earlier than later. I think we should probably backport changes that:

  • Modify existing CI configurations / scripts
  • Modify existing tests / testing utilities

@gfyoung
Copy link
Member Author

gfyoung commented Sep 10, 2018

#22213 may be the one to fix locales.

@TomAugspurger : Ah, thanks for pointing that out. Let me see if that solves anything...

@gfyoung
Copy link
Member Author

gfyoung commented Sep 11, 2018

@jreback @TomAugspurger : Well would you look at that? That seemed to have done the trick! All tests are passing now with Circle 2.0. PTAL.

@TomAugspurger
Copy link
Contributor

LGTM at a glance, thanks. Feel free to merge when you're ready (probably rebase & merge since it's a backport branch).

@gfyoung
Copy link
Member Author

gfyoung commented Sep 11, 2018

@TomAugspurger : This is against the 0.23.x branch, so I think we're good here.

@gfyoung gfyoung merged commit 183e92f into pandas-dev:0.23.x Sep 11, 2018
@gfyoung gfyoung deleted the ci-backports branch September 11, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants