BUG: NaN should have pct rank of NaN #22634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Groupby
Missing-data
|
Hello @gfyoung! Thanks for submitting the PR.
|
|
@jreback @TomAugspurger : Looks like we need to backport #22601 and #21814 too? |
|
@gfyoung yep those CI backport are needed |
|
@jreback : Yep, sounds good. |
gfyoung
force-pushed
the
group-rank-nan-backport
branch
from
d12f1d0 to
349e939
Compare
Codecov Report
@@ Coverage Diff @@
## 0.23.x #22634 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 153 153
Lines 49588 49588
=======================================
Hits 45543 45543
Misses 4045 4045
Continue to review full report at Codecov.
|
|
This is a clean backport, and with all tests now passing, going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #22600.