Skip to content

CI: Unpin openpyxl #22605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomAugspurger opened this issue Sep 5, 2018 · 8 comments
Closed

CI: Unpin openpyxl #22605

TomAugspurger opened this issue Sep 5, 2018 · 8 comments
Labels
CI Continuous Integration

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Sep 5, 2018

Followup to #22601 and dask/dask-ml#84 (comment).

Upstream issue: https://bitbucket.org/openpyxl/openpyxl/issues/1094/error-with-pandas-datetimeindex

(one of several in fact filed for this issue)

@TomAugspurger TomAugspurger added the CI Continuous Integration label Sep 5, 2018
@jreback jreback added this to the 0.24.0 milestone Sep 5, 2018
@gfyoung
Copy link
Member

gfyoung commented Sep 5, 2018

Upstream commit just came in to patch this:

https://bitbucket.org/openpyxl/openpyxl/commits/fa13fbfda13a

Need to wait on next release to unpin this.

@jreback jreback modified the milestones: 0.24.0, 0.24.1 Dec 2, 2018
@h-vetinari
Copy link
Contributor

Reported error in https://bitbucket.org/openpyxl/openpyxl/issues/1094/error-with-pandas-datetimeindex (thru being duplicate of https://bitbucket.org/openpyxl/openpyxl/issues/1093/newly-introduced-keyerror-problem-in) was fixed in 2.5.7 apparently - current version is 2.5.12. Tagging @alimcmaster1, as he asked about just that on the bitbucket tracker.

@alimcmaster1
Copy link
Member

@h-vetinari . I already largely did this #23361 the only build that's that remain pinned are azure-macOS-35, and azure-27-compat build. So I think this is perhaps fine to close unless anyone thinks there is something else we should be doing here?

@gfyoung
Copy link
Member

gfyoung commented Jan 27, 2019

@jreback @TomAugspurger : Do we intend to unpin openpyxl for these two builds?

Otherwise, I do agree that we should close this (and mark for 0.24.0 instead of 0.24.1 in fact).

@jreback
Copy link
Contributor

jreback commented Jan 30, 2019

are we pinning anywhere?

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jan 30, 2019

ci/deps/travis-27.yaml
21:  - openpyxl=2.4.0

ci/deps/azure-27-compat.yaml
11:  - openpyxl=2.5.5

ci/deps/azure-macos-35.yaml
15:  - openpyxl=2.5.5

ci/deps/azure-27-locale.yaml
11:  - openpyxl=2.4.0

We have builds that are not pinned though, so this is probably fine to close. Or some of the ones pinned at 2.5.5 can be lifted, either works for me.

@gfyoung
Copy link
Member

gfyoung commented Feb 2, 2019

The Azure pins I believe were explicitly requested by @jreback when #23361 was merged. Not sure about the Travis one though.

@jreback : Thoughts?

@TomAugspurger TomAugspurger modified the milestones: 0.24.1, 0.24.2 Feb 3, 2019
@TomAugspurger
Copy link
Contributor Author

Closing, since we have a mix of pinned & unpinned.

@TomAugspurger TomAugspurger modified the milestones: 0.24.2, No action Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

No branches or pull requests

5 participants