Skip to content

Corrected to necessary pip requirements format #22749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vadakattu
Copy link
Contributor

Requirements format for building pip env requires '==' instead of '='

@alimcmaster1
Copy link
Member

Looks good to me, thanks
CC @gfyoung

@TomAugspurger
Copy link
Contributor

That file is autogenerated. We need to update scripts/convert_deps.py to turn = into == for pip.

@TomAugspurger
Copy link
Contributor

And then run scripts/convert_deps.py to regenerate the file.

@gfyoung
Copy link
Member

gfyoung commented Sep 19, 2018

Second what @TomAugspurger said above. Good catch, @vadakattu !

@gfyoung gfyoung added Build Library building on various platforms Dependencies Required and optional dependencies labels Sep 21, 2018
@jreback jreback added this to the 0.24.0 milestone Sep 23, 2018
@jorisvandenbossche
Copy link
Member

@vadakattu do you have time to update this?

@vadakattu
Copy link
Contributor Author

vadakattu commented Sep 25, 2018 via email

@vadakattu
Copy link
Contributor Author

Seems to have been resolved in the meantime by #22889

@vadakattu vadakattu deleted the pip-optional-reqs-openpyxml branch October 3, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants