Skip to content

Merge master into realtime-rc-merge and use Firebase executors. #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 93 commits into from
Dec 22, 2022

Conversation

danasilver
Copy link
Contributor

@danasilver danasilver commented Dec 20, 2022

Builds and tests pass locally.

argzdev and others added 30 commits October 21, 2022 12:05
This implementation:

- Creates the base branch (name is based in user input)
- Creates the release branch (name is based in user input)
- Creates the release.cfg file in the release branch without adding
  any SDK (module) to it.

It can create the branches based on any existing branch of the repo.
* Update versions
* WIP: `in` expansion.

* Add composite filter in-expansion test.

* Fix formatting.

* Run in-expansion as part of DNF computation and add tests.

* Add test with nested IN filters with CSI.

* Add tests for other cases.
* refactor(functions): update firebase-iid to 21.1.0

* Update CHANGELOG.md

* Update CHANGELOG.md

* bump firebase-iid-interop to 17.1.0

* exclude firebase-components from firebase-iid dependency
firebase-database only uses StringUtils#repeat in test code, and it is
easy to port repeat method to test file and remove plexus-utils
from test dependency.

Signed-off-by: utzcoz <[email protected]>

Signed-off-by: utzcoz <[email protected]>
* test(functions): fix instrumentation tests

* fix java format
Properly reset SharedPreferences test state in between each test.
* Remove redundant package list

* Implement fix for link transformations

* Set reference path in DackkaPlugin

* Removed accidental dackka diff script
* Early return in getDocumentsMatchingTarget

* Address Feedback
* Upgrade GRPC tp 1.50.2

* Add changelog for Upgrade GRPC tp 1.50.2

* Add links to changelog
* Add groupId removal transform

* Add bug link for dackka exposing the configuration
* Initial version of the build release artifacts workflow.

This version of the workflow hardcodes the list of sdks to release to
include Firestore only. Also, generated javadoc is not yet equivalent
to what's generated by the regular release process.
This will make it easier to identify them and apply restrictions on them.
* Fix code blocks

* Fix linting in firebase-database

* Fix FirebaseMLDownloader linting
)

* predraw and uptimeMillis

* fix send event

* fix dangling variable and naming

* copyright

* fix test

* onStop

* test

* better readability

* comments

* reduce code

* reset
* fix flaky test

* word smithing
vkryachko and others added 14 commits December 12, 2022 11:05
* Integrate `SafetyNetAppCheckProvider` with Firebase Components.

* Suppress warning.

* Integrate DebugAppCheckProvider with Firebase Components.

* Add unit tests for the new registrars.

* Integrate `PlayIntegrityAppCheckProvider` with Firebase Components.
…#4440)

Migrate firebase-inappmessaging SDK to go/firebase-android-executors.
…4449)

* Migrate `firebase-appcheck-safetynet` to go/firebase-android-executors.

* Migrate `firebase-appcheck-playintegrity` to go/firebase-android-executors.

* Migrate `firebase-appcheck-debug` to go/firebase-android-executors.

* Remove unnecessary class field from `SafetyNetAppCheckProvider`.

* Update changelogs.
* Migrate core libraries to Gradle Kotlin DSL.

* update

* Add functions, fix tests

* fix docs

* fix functions ktx minSdk version.

* Apply suggestions from code review

Co-authored-by: Rodrigo Lazo <[email protected]>

Co-authored-by: Rodrigo Lazo <[email protected]>
…#4442)

* Fix overlay patch bug

* Feedback

* Delete comment
* Add diff javadoc workflow

* Minor tweaks

* Revert checkout order change

* Revert incorrect changes

* Modify ChangedModulesTask

* Only compare modified SDKs

* Change build order

* Add fetch depth

* Fix typo

* Only Firebase SDKs
* Move continuations off main thread for `firebase-appcheck`.

* One more continuation in `firebase-appcheck`.

* Move continuations off main thread for `firebase-appcheck-debug`.

* Rearrange executor order.

* Move continuations off main thread for `firebase-appcheck-safetynet`.

* Move continuations off main thread for `firebase-appcheck-playintegrity`.

* Update changelog.

* Fix `SafetyNetAppCheckProviderTest`.

* Address review comments.
* update dagger

* update

* update

* update

* update registrar

* update tests
@danasilver danasilver changed the base branch from realtime-rc-merge to master December 20, 2022 04:57
@danasilver danasilver changed the base branch from master to realtime-rc-merge December 20, 2022 04:57
@danasilver danasilver changed the title Ds realtime rc merge master Merge master into realtime-rc-merge and use Firebase executors. Dec 20, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2022

Size Report 1

Affected Products

  • firebase-abt

    TypeBase (e40042a)Merge (8978980)Diff
    aar13.8 kB13.8 kB-8 B (-0.1%)
    apk (aggressive)85.8 kB116 kB+29.9 kB (+34.9%)
    apk (release)688 kB1.27 MB+579 kB (+84.2%)
  • firebase-annotations

    TypeBase (e40042a)Merge (8978980)Diff
    apk (release)8.89 kB9.46 kB+568 B (+6.4%)
  • firebase-appcheck

    TypeBase (e40042a)Merge (8978980)Diff
    aar37.6 kB36.6 kB-1.06 kB (-2.8%)
    apk (aggressive)332 kB361 kB+28.9 kB (+8.7%)
    apk (release)978 kB1.56 MB+580 kB (+59.4%)
  • firebase-appcheck-debug

    TypeBase (e40042a)Merge (8978980)Diff
    aar11.6 kB11.1 kB-414 B (-3.6%)
    apk (aggressive)332 kB362 kB+29.9 kB (+9.0%)
    apk (release)980 kB1.56 MB+580 kB (+59.2%)
  • firebase-appcheck-debug-testing

    TypeBase (e40042a)Merge (8978980)Diff
    aar6.26 kB7.27 kB+1.01 kB (+16.1%)
    apk (aggressive)334 kB364 kB+30.2 kB (+9.1%)
    apk (release)1.02 MB1.60 MB+579 kB (+56.9%)
  • firebase-appcheck-interop

    TypeBase (e40042a)Merge (8978980)Diff
    aar5.03 kB5.02 kB-2 B (-0.0%)
    apk (aggressive)329 kB358 kB+28.9 kB (+8.8%)
    apk (release)966 kB1.54 MB+577 kB (+59.7%)
  • firebase-appcheck-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar5.98 kB5.98 kB+2 B (+0.0%)
    apk (aggressive)356 kB369 kB+12.7 kB (+3.6%)
    apk (release)1.92 MB1.94 MB+20.8 kB (+1.1%)
  • firebase-appcheck-playintegrity

    TypeBase (e40042a)Merge (8978980)Diff
    aar10.1 kB11.0 kB+860 B (+8.5%)
    apk (aggressive)332 kB364 kB+32.0 kB (+9.6%)
    apk (release)991 kB1.57 MB+578 kB (+58.3%)
  • firebase-appcheck-safetynet

    TypeBase (e40042a)Merge (8978980)Diff
    aar12.1 kB10.4 kB-1.75 kB (-14.5%)
    apk (aggressive)332 kB363 kB+30.8 kB (+9.3%)
    apk (release)992 kB1.57 MB+578 kB (+58.2%)
  • firebase-appdistribution

    TypeBase (e40042a)Merge (8978980)Diff
    aar140 kB140 kB+221 B (+0.2%)
    apk (aggressive)777 kB801 kB+24.2 kB (+3.1%)
    apk (release)2.00 MB2.57 MB+569 kB (+28.5%)
  • firebase-appdistribution-api

    TypeBase (e40042a)Merge (8978980)Diff
    aar14.2 kB14.2 kB+38 B (+0.3%)
    apk (aggressive)85.8 kB112 kB+25.9 kB (+30.2%)
    apk (release)689 kB1.27 MB+577 kB (+83.8%)
  • firebase-appdistribution-api-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar5.84 kB5.83 kB-4 B (-0.1%)
    apk (aggressive)110 kB124 kB+13.8 kB (+12.5%)
    apk (release)1.63 MB1.65 MB+20.1 kB (+1.2%)
  • firebase-common

    TypeBase (e40042a)Merge (8978980)Diff
    aar50.1 kB67.4 kB+17.3 kB (+34.5%)
    apk (aggressive)85.1 kB111 kB+25.9 kB (+30.4%)
    apk (release)683 kB1.26 MB+577 kB (+84.5%)
  • firebase-common-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar6.03 kB13.2 kB+7.22 kB (+119.7%)
    apk (aggressive)109 kB123 kB+13.8 kB (+12.7%)
    apk (release)1.62 MB1.64 MB+20.6 kB (+1.3%)
  • firebase-components

    TypeBase (e40042a)Merge (8978980)Diff
    aar42.8 kB44.9 kB+2.19 kB (+5.1%)
    apk (aggressive)8.68 kB23.1 kB+14.4 kB (+165.7%)
    apk (release)31.9 kB596 kB+564 kB (+1768.8%)
  • firebase-config

    TypeBase (e40042a)Merge (8978980)Diff
    aar88.7 kB88.9 kB+179 B (+0.2%)
    apk (aggressive)121 kB149 kB+28.8 kB (+23.9%)
    apk (release)746 kB1.32 MB+578 kB (+77.5%)
  • firebase-config-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar5.58 kB5.58 kB+6 B (+0.1%)
    apk (aggressive)145 kB158 kB+13.3 kB (+9.2%)
    apk (release)1.68 MB1.70 MB+19.8 kB (+1.2%)
  • firebase-crashlytics

    TypeBase (e40042a)Merge (8978980)Diff
    aar341 kB342 kB+261 B (+0.1%)
    apk (aggressive)217 kB242 kB+24.7 kB (+11.4%)
    apk (release)895 kB1.47 MB+575 kB (+64.2%)
  • firebase-crashlytics-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar6.59 kB6.57 kB-18 B (-0.3%)
    apk (aggressive)237 kB249 kB+12.2 kB (+5.2%)
    apk (release)1.83 MB1.85 MB+21.3 kB (+1.2%)
  • firebase-crashlytics-ndk

    TypeBase (e40042a)Merge (8978980)Diff
    aar1.67 MB1.63 MB-39.5 kB (-2.4%)
    apk (aggressive / arm64-v8a)1.33 MB1.40 MB+67.7 kB (+5.1%)
    apk (aggressive / armeabi-v7a)838 kB877 kB+38.9 kB (+4.6%)
    apk (aggressive / x86)1.38 MB1.38 MB+2.43 kB (+0.2%)
    apk (aggressive / x86_64)1.43 MB1.44 MB+6.33 kB (+0.4%)
    apk (release / arm64-v8a)2.00 MB2.62 MB+617 kB (+30.8%)
    apk (release / armeabi-v7a)1.51 MB2.10 MB+588 kB (+38.8%)
    apk (release / x86)2.05 MB2.60 MB+551 kB (+26.9%)
    apk (release / x86_64)2.11 MB2.67 MB+555 kB (+26.3%)
  • firebase-database

    TypeBase (e40042a)Merge (8978980)Diff
    aar488 kB488 kB+255 B (+0.1%)
    apk (aggressive)330 kB359 kB+29.0 kB (+8.8%)
    apk (release)1.14 MB1.72 MB+574 kB (+50.3%)
  • firebase-database-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar22.6 kB22.6 kB-11 B (-0.0%)
    apk (aggressive)354 kB367 kB+12.8 kB (+3.6%)
    apk (release)2.08 MB2.10 MB+22.0 kB (+1.1%)
  • firebase-datatransport

    TypeBase (e40042a)Merge (8978980)Diff
    aar4.94 kB4.94 kB+7 B (+0.1%)
    apk (aggressive)136 kB161 kB+25.3 kB (+18.7%)
    apk (release)771 kB1.35 MB+578 kB (+75.0%)
  • firebase-dynamic-links

    TypeBase (e40042a)Merge (8978980)Diff
    aar54.6 kB54.6 kB-6 B (-0.0%)
    apk (aggressive)331 kB360 kB+28.9 kB (+8.7%)
    apk (release)979 kB1.56 MB+580 kB (+59.2%)
  • firebase-dynamic-links-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar8.28 kB8.28 kB-1 B (-0.0%)
    apk (aggressive)355 kB367 kB+12.8 kB (+3.6%)
    apk (release)1.92 MB1.94 MB+21.6 kB (+1.1%)
  • firebase-dynamic-module-support

    TypeBase (e40042a)Merge (8978980)Diff
    apk (aggressive)94.3 kB124 kB+29.5 kB (+31.2%)
    apk (release)735 kB1.31 MB+578 kB (+78.6%)
  • firebase-firestore

    TypeBase (e40042a)Merge (8978980)Diff
    aar1.30 MB1.31 MB+1.55 kB (+0.1%)
    apk (aggressive)492 kB517 kB+24.4 kB (+5.0%)
    apk (release)3.32 MB3.93 MB+611 kB (+18.4%)
  • firebase-firestore-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar13.7 kB13.5 kB-149 B (-1.1%)
    apk (aggressive)512 kB525 kB+12.7 kB (+2.5%)
    apk (release)4.26 MB4.31 MB+53.5 kB (+1.3%)
  • firebase-functions

    TypeBase (e40042a)Merge (8978980)Diff
    aar25.8 kB45.3 kB+19.5 kB (+75.8%)
    apk (aggressive)399 kB399 kB+841 B (+0.2%)
    apk (release)1.21 MB1.81 MB+603 kB (+49.8%)
  • firebase-functions-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar5.69 kB5.69 kB+1 B (+0.0%)
    apk (aggressive)418 kB408 kB-10.7 kB (-2.5%)
    apk (release)2.15 MB2.19 MB+47.2 kB (+2.2%)
  • firebase-inappmessaging

    TypeBase (e40042a)Merge (8978980)Diff
    aar470 kB450 kB-19.3 kB (-4.1%)
    apk (aggressive)665 kB696 kB+30.9 kB (+4.6%)
    apk (release)3.36 MB3.95 MB+592 kB (+17.6%)
  • firebase-inappmessaging-display

    TypeBase (e40042a)Merge (8978980)Diff
    aar201 kB180 kB-21.2 kB (-10.6%)
    apk (aggressive)1.50 MB1.53 MB+29.7 kB (+2.0%)
    apk (release)4.61 MB5.21 MB+601 kB (+13.1%)
  • firebase-inappmessaging-display-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar17.6 kB17.6 kB-3 B (-0.0%)
    apk (aggressive)1.52 MB1.54 MB+18.3 kB (+1.2%)
    apk (release)5.55 MB5.59 MB+42.9 kB (+0.8%)
  • firebase-inappmessaging-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar5.02 kB5.03 kB+5 B (+0.1%)
    apk (aggressive)685 kB704 kB+19.3 kB (+2.8%)
    apk (release)4.29 MB4.33 MB+37.5 kB (+0.9%)
  • firebase-installations

    TypeBase (e40042a)Merge (8978980)Diff
    aar54.9 kB55.0 kB+110 B (+0.2%)
    apk (aggressive)86.5 kB116 kB+29.9 kB (+34.6%)
    apk (release)706 kB1.28 MB+577 kB (+81.7%)
  • firebase-installations-interop

    TypeBase (e40042a)Merge (8978980)Diff
    aar8.06 kB8.05 kB-2 B (-0.0%)
    apk (release)651 kB651 kB+300 B (+0.0%)
  • firebase-installations-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar5.01 kB5.00 kB-1 B (-0.0%)
    apk (aggressive)111 kB125 kB+13.8 kB (+12.4%)
    apk (release)1.64 MB1.67 MB+22.1 kB (+1.3%)
  • firebase-messaging

    TypeBase (e40042a)Merge (8978980)Diff
    aar142 kB142 kB+243 B (+0.2%)
    apk (aggressive)440 kB463 kB+23.2 kB (+5.3%)
    apk (release)1.14 MB1.72 MB+576 kB (+50.5%)
  • firebase-messaging-directboot

    TypeBase (e40042a)Merge (8978980)Diff
    aar8.76 kB5.12 kB-3.63 kB (-41.5%)
    apk (aggressive)440 kB464 kB+23.1 kB (+5.2%)
    apk (release)1.14 MB1.72 MB+575 kB (+50.3%)
  • firebase-messaging-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar6.10 kB6.10 kB+3 B (+0.0%)
    apk (aggressive)460 kB471 kB+10.8 kB (+2.3%)
    apk (release)2.08 MB2.10 MB+19.1 kB (+0.9%)
  • firebase-ml-modeldownloader

    TypeBase (e40042a)Merge (8978980)Diff
    aar87.4 kB118 kB+30.6 kB (+35.0%)
    apk (aggressive)143 kB166 kB+22.5 kB (+15.7%)
    apk (release)823 kB1.41 MB+584 kB (+71.0%)
  • firebase-ml-modeldownloader-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar6.10 kB6.10 kB-2 B (-0.0%)
    apk (aggressive)163 kB174 kB+10.5 kB (+6.4%)
    apk (release)1.76 MB1.79 MB+26.5 kB (+1.5%)
  • firebase-perf

    TypeBase (e40042a)Merge (8978980)Diff
    aar311 kB313 kB+1.83 kB (+0.6%)
    apk (aggressive)1.05 MB1.08 MB+25.1 kB (+2.4%)
    apk (release)2.48 MB3.06 MB+574 kB (+23.1%)
  • firebase-perf-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar16.0 kB16.0 kB-5 B (-0.0%)
    apk (aggressive)1.07 MB1.09 MB+13.7 kB (+1.3%)
    apk (release)3.42 MB3.44 MB+22.8 kB (+0.7%)
  • firebase-segmentation

    TypeBase (e40042a)Merge (8978980)Diff
    aar20.0 kB20.2 kB+214 B (+1.1%)
    apk (aggressive)87.1 kB117 kB+29.8 kB (+34.2%)
    apk (release)712 kB1.29 MB+579 kB (+81.4%)
  • firebase-storage

    TypeBase (e40042a)Merge (8978980)Diff
    aar116 kB116 kB+227 B (+0.2%)
    apk (aggressive)330 kB359 kB+28.9 kB (+8.8%)
    apk (release)1.01 MB1.59 MB+579 kB (+57.5%)
  • firebase-storage-ktx

    TypeBase (e40042a)Merge (8978980)Diff
    aar13.1 kB13.1 kB-8 B (-0.1%)
    apk (aggressive)354 kB366 kB+12.8 kB (+3.6%)
    apk (release)1.95 MB1.97 MB+22.1 kB (+1.1%)
  • transport-backend-cct

    TypeBase (e40042a)Merge (8978980)Diff
    aar53.6 kB53.6 kB-1 B (-0.0%)
    apk (release)105 kB105 kB+20 B (+0.0%)
  • transport-runtime

    TypeBase (e40042a)Merge (8978980)Diff
    aar180 kB180 kB+107 B (+0.1%)
    apk (release)83.5 kB83.5 kB-28 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ltVWSFX2J8.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2022

Coverage Report 1

This report is too large (200,680 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/E3uY56rCRA.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 20, 2022

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (8978980) and the base commit (e40042a) are not available.

No macrobenchmark data found for the base commit (e40042a). Analysis for the CI merge commit (8978980) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Lfu9KuQ8zf/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

Unit Test Results

   391 files     391 suites   17m 48s ⏱️
4 525 tests 4 502 ✔️ 22 💤 1
4 541 runs  4 518 ✔️ 22 💤 1

For more details on these failures, see this check.

Results for commit e7ad15d.

♻️ This comment has been updated with latest results.

@danasilver danasilver requested a review from qdpham13 December 20, 2022 17:49
Copy link
Contributor

@qdpham13 qdpham13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danasilver danasilver merged commit 2e94bb7 into realtime-rc-merge Dec 22, 2022
@danasilver danasilver deleted the ds-realtime-rc-merge-master branch December 22, 2022 18:24
danasilver added a commit that referenced this pull request Dec 22, 2022
@firebase firebase locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.