Skip to content

Remove @Deprecated annotations from App Check SafetyNet SDK #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

Remove @Deprecated annotations from App Check SafetyNet SDK #4289

merged 1 commit into from
Nov 8, 2022

Conversation

rosalyntan
Copy link
Member

Remove the @Deprecated annotations added in #4187, as we are instead marking the SDK as deprecated in Android Studio.

The change in #4187 was never released, so it is not necessary to release with this update.

@rosalyntan rosalyntan requested a review from vkryachko November 7, 2022 21:41
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appcheck-safetynet

    Overall coverage changed from ? (bcdf4a9) to 81.82% (319b686) by ?.

    FilenameBase (bcdf4a9)Merge (319b686)Diff
    ExchangeSafetyNetTokenRequest.java?100.00%?
    FirebaseAppCheckSafetyNetRegistrar.java?0.00%?
    SafetyNetAppCheckProvider.java?83.33%?
    SafetyNetAppCheckProviderFactory.java?66.67%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sGtbRIS0XQ.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Unit Test Results

14 tests   - 154   14 ✔️  - 154   24s ⏱️ - 3m 50s
  4 suites  -   23     0 💤 ±    0 
  4 files    -   23     0 ❌ ±    0 

Results for commit c08fa8d. ± Comparison against base commit bcdf4a9.

This pull request removes 165 and adds 11 tests. Note that renamed tests count towards both. 
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
…

com.google.firebase.appcheck.safetynet.SafetyNetAppCheckProviderFactoryTest ‑ testGetInstance_callTwice_sameInstance
com.google.firebase.appcheck.safetynet.internal.ExchangeSafetyNetTokenRequestTest ‑ toJsonString_expectSerialized
com.google.firebase.appcheck.safetynet.internal.SafetyNetAppCheckProviderTest ‑ exchangeSafetyNetJwsForToken_onFailure_setsTaskException
com.google.firebase.appcheck.safetynet.internal.SafetyNetAppCheckProviderTest ‑ exchangeSafetyNetJwsForToken_onSuccess_setsTaskResult
com.google.firebase.appcheck.safetynet.internal.SafetyNetAppCheckProviderTest ‑ testConstructor_googlePlayServicesIsNotAvailable_expectSafetyNetClientTaskException
com.google.firebase.appcheck.safetynet.internal.SafetyNetAppCheckProviderTest ‑ testExchangeSafetyNetJwsForToken_emptySafetyNetJwsResult_expectThrows
com.google.firebase.appcheck.safetynet.internal.SafetyNetAppCheckProviderTest ‑ testExchangeSafetyNetJwsForToken_nullAttestationResponse_expectThrows
com.google.firebase.appcheck.safetynet.internal.SafetyNetAppCheckProviderTest ‑ testExchangeSafetyNetJwsForToken_validFields_expectReturnsTask
com.google.firebase.appcheck.safetynet.internal.SafetyNetAppCheckProviderTest ‑ testGetToken_googlePlayServicesIsNotAvailable_expectGetTokenTaskException
com.google.firebase.appcheck.safetynet.internal.SafetyNetAppCheckProviderTest ‑ testGetToken_nonNullSafetyNetClient_expectCallsSafetyNetForAttestation
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appcheck-safetynet

    TypeBase (bcdf4a9)Merge (319b686)Diff
    aar12.1 kB12.1 kB-35 B (-0.3%)
    apk (release)992 kB992 kB-12 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/a0Ka9CnANX.html

@rosalyntan rosalyntan merged commit 0bd205d into master Nov 8, 2022
@rosalyntan rosalyntan deleted the rosalyntan.safetynet branch November 8, 2022 00:02
davidmotson pushed a commit that referenced this pull request Nov 28, 2022
@rosalyntan
Remove @Deprecated annotations. (#4289)
73579c3
@firebase firebase locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosalyntan @google-oss-bot @vkryachko