Fix flakiness in MessagingAnalyticsRoboTest.java

[willxu-google]

Properly reset SharedPreferences test state in between each test.

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-messaging

  Overall coverage changed from ? (854cba5) to 85.42% (b7eae03) by ?.

  41 individual files with coverage change

  Filename	Base (854cba5)	Merge (b7eae03)	Diff
  AutoProtoEncoderDoNotUseEncoder.java	?	98.17%	?
  ByteStreams.java	?	59.72%	?
  CommonNotificationBuilder.java	?	90.78%	?
  Constants.java	?	92.86%	?
  DisplayNotification.java	?	91.38%	?
  EnhancedIntentService.java	?	76.60%	?
  ExecutorFactory.java	?	0.00%	?
  FcmBroadcastProcessor.java	?	93.33%	?
  FcmExecutors.java	?	80.00%	?
  FcmLifecycleCallbacks.java	?	89.29%	?
  FirebaseInstanceIdReceiver.java	?	72.73%	?
  FirebaseMessaging.java	?	77.09%	?
  FirebaseMessagingRegistrar.java	?	100.00%	?
  FirebaseMessagingService.java	?	94.03%	?
  GmsRpc.java	?	83.15%	?
  ImageDownload.java	?	93.33%	?
  MessagingAnalytics.java	?	81.78%	?
  MessagingClientEvent.java	?	93.58%	?
  MessagingClientEventExtension.java	?	76.47%	?
  Metadata.java	?	61.90%	?
  NotificationParams.java	?	98.71%	?
  PoolableExecutors.java	?	29.17%	?
  ProtoEncoderDoNotUse.java	?	50.00%	?
  ProxyNotificationInitializer.java	?	93.75%	?
  ProxyNotificationPreferences.java	?	88.89%	?
  RemoteMessage.java	?	95.48%	?
  RemoteMessageCreator.java	?	88.89%	?
  RequestDeduplicator.java	?	90.00%	?
  SendException.java	?	100.00%	?
  ServiceStarter.java	?	87.50%	?
  SharedPreferencesQueue.java	?	98.65%	?
  Store.java	?	74.19%	?
  SyncTask.java	?	70.83%	?
  ThreadPriority.java	?	100.00%	?
  TopicOperation.java	?	90.00%	?
  TopicsStore.java	?	100.00%	?
  TopicsSubscriber.java	?	89.47%	?
  TopicsSyncTask.java	?	53.33%	?
  WakeLockHolder.java	?	96.08%	?
  WithinAppServiceBinder.java	?	90.91%	?
  WithinAppServiceConnection.java	?	84.15%	?

Test Logs

• Merge (b7eae03): https://github.com/firebase/firebase-android-sdk/actions/runs/3348389076

1. https://storage.googleapis.com/firebase-sdk-metric-reports/1Rc4Ht41b1.html

[github-actions]

Unit Test Results

474 tests  +468   474 ✔️ +468   3m 55s ⏱️ + 3m 38s
  27 suites +  24       0 💤 ±    0 
  27 files   +  24       0 ❌ ±    0 

Results for commit 2554da7. ± Comparison against base commit 854cba5.

This pull request removes 6 and adds 474 tests. Note that renamed tests count towards both.

com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.ktx.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.ktx.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.ktx.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
com.google.firebase.functions.ktx.FunctionsTests ‑ functions should delegate to FirebaseFunctions#getInstance()
com.google.firebase.functions.ktx.LibraryVersionTest ‑ library version should be registered with runtime

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testBindsService_oAndTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_OTargetingO_highPriority
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_fallsBackToBindService
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[19]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
…

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (854cba5) and merge commit (b7eae03).

Test Logs

• Base (854cba5): https://github.com/firebase/firebase-android-sdk/actions/runs/3339706777
• Merge (b7eae03): https://github.com/firebase/firebase-android-sdk/actions/runs/3348389076

1. https://storage.googleapis.com/firebase-sdk-metric-reports/7b0dggfO22.html

[gsakakihara]

The coverage test failure appears to be in an unrelated project and I don't see how this change could be causing it, but you should check to make sure.

Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

This probably should be fixed, just adding the 'no-changelog' label since this is a test-only change that shouldn't be included in the release notes.