Initial version of the build release artifacts workflow. #4287
Conversation
This version of the workflow hardcodes the list of sdks to release to include Firestore only. Also, generated javadoc is not yet equivalent to what's generated by the regular release process.
Size Report 1Affected ProductsNo changes between base commit (bcdf4a9) and merge commit (a989ccc).Test Logs |
| - 'releases/**' | ||
|
|
||
| jobs: | ||
| create-branches: |
There was a problem hiding this comment.
The job is named "create-branches", but does it actually create any branch?
|
|
||
| - name: Perform gradle build | ||
| run: | | ||
| ./gradlew firebasePublish -PprojectsToPublish=firebase-firestore -PpublishMode=RELEASE -PincludeFireEscapeArtifacts=true |
There was a problem hiding this comment.
I think hardcoding is good in this initial version. Eventually we want to make the value of -PprojectsToPublish coming from release.cfg?
What I'm thinking -- Maybe we can make a custom action around release.cfg (for its creation, parsing, etc). That way it is possible to be used in multiple workflows and its input/output format can be defined based on its intended usage.
Although this is just one way to design it.
There was a problem hiding this comment.
Yes, we don't have this define just yet. One idea is to have a gradle command that's going to output the list of projects to publish direclty, and then use that output as input for this command. Or, we can tentatively use the configuration too.
Now that you bring it up, we can use the configuration, and as fallback, use the command, if available. I'll do it in a follow up PR. Thanks!
| workflow_dispatch: | ||
| pull_request: | ||
| branches: | ||
| - 'releases/**' |
There was a problem hiding this comment.
I thought the release branches are named *.release in create_releases.yml?
There was a problem hiding this comment.
branches: limits what target branches the action applies to. What we currently do, for example, is:
M122 <-- M122.release
The PR has as target 'M122'. I'm going to change create_releases.yml to prepend releases/ to both branches. It's going to look like this
releases/M122 <--- releases/M122.release
then the check will work
* Initial version of the build release artifacts workflow. This version of the workflow hardcodes the list of sdks to release to include Firestore only. Also, generated javadoc is not yet equivalent to what's generated by the regular release process.
This version of the workflow hardcodes the list of sdks to release to include Firestore only. Also, generated javadoc is not yet equivalent to what's generated by the regular release process.