-
Notifications
You must be signed in to change notification settings - Fork 617
Initial version of the build release artifacts workflow. #4287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
name: Build Release Artifacts | ||
|
||
on: | ||
workflow_dispatch: | ||
pull_request: | ||
branches: | ||
- 'releases/**' | ||
|
||
jobs: | ||
create-branches: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The job is named "create-branches", but does it actually create any branch? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
runs-on: ubuntu-latest | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Perform gradle build | ||
run: | | ||
./gradlew firebasePublish -PprojectsToPublish=firebase-firestore -PpublishMode=RELEASE -PincludeFireEscapeArtifacts=true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think hardcoding is good in this initial version. Eventually we want to make the value of What I'm thinking -- Maybe we can make a custom action around Although this is just one way to design it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we don't have this define just yet. One idea is to have a gradle command that's going to output the list of projects to publish direclty, and then use that output as input for this command. Or, we can tentatively use the configuration too. Now that you bring it up, we can use the configuration, and as fallback, use the command, if available. I'll do it in a follow up PR. Thanks! |
||
- name: Upload generated artifacts | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: release_artifacts.zip | ||
path: build/*.zip | ||
retention-days: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the release branches are named
*.release
in create_releases.yml?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branches:
limits what target branches the action applies to. What we currently do, for example, is:M122 <-- M122.release
The PR has as target 'M122'. I'm going to change
create_releases.yml
to prependreleases/
to both branches. It's going to look like thisreleases/M122 <--- releases/M122.release
then the check will work