Fix Javadoc link generation in Dackka #4258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected ProductsNo changes between base commit (ffca832) and merge commit (dceba7d).Test Logs |
rlazo
reviewed
Oct 28, 2022
rlazo
approved these changes
Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/254698771,
this refactors the link transformation in Dackka to me more inclusive. More specifically, it transforms links across yaml AND HTML files. Natively, Dackka does not provide any behavior to change the structure of links, so our Java links were being generated without the
/androiddirectory. We now expose configuration in ourFiresiteTransfromtask that allows the consumer to specify these directories.