Remove deprecated constructors #3768
Conversation
tautschnig
commented
Jan 11, 2019
tautschnig
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
tautschnig
requested review from
allredj,
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
martin-cs,
NathanJPhillips,
peterschrammel,
pkesseli,
romainbrenguier,
smowton and
thk123
as code owners
tautschnig
force-pushed
the
remove-deprecated-constructors
branch
4 times, most recently
from
c53b962 to
1258230
Compare
|
Are reviews still required / desired for this? |
tautschnig
force-pushed
the
remove-deprecated-constructors
branch
from
1258230 to
5621d77
Compare
tautschnig
changed the title
Construct array_exprt in a non-deprecated way [blocks: #3768]
…ator Add an identifier-based lookup to constant_propagator_is_constantt [blocks: #3768]
tautschnig
changed the title
Use generic exprt to avoid deprecated default constructor of symbol_exprt [blocks: #3768]
tautschnig
force-pushed
the
remove-deprecated-constructors
branch
2 times, most recently
from
ccdaa86 to
608f3ed
Compare
tautschnig
force-pushed
the
remove-deprecated-constructors
branch
from
1b51603 to
06ffaa0
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 06ffaa0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105558030
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
tautschnig
force-pushed
the
remove-deprecated-constructors
branch
from
06ffaa0 to
45d950e
Compare
tautschnig
requested review from
danpoe and
hannes-steffenhagen-diffblue
as code owners
tautschnig
changed the title
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 45d950e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105559944
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
|
Updated TG - rebasing this should get the Joel bot to pass |
These have been deprecated since 21 Sept 2018.
These have been deprecated since 21 Sept 2018.
These have been marked deprecated for several months.
tautschnig
force-pushed
the
remove-deprecated-constructors
branch
from
45d950e to
370ec81
Compare
tautschnig
removed
Needs TG approval 🦉
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 370ec81).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105883753
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
