Skip to content

Use generic exprt to avoid deprecated default constructor of symbol_exprt [blocks: #3768] #3870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

tautschnig
Copy link
Collaborator

The implementation here is highly incomplete, in particular those symbols are
never set. If at some future date the implementation is completed then the type
of those members might be changed again.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 0c566ef).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98059524

@kroening
Copy link
Member

Use optionalt instead?

@tautschnig tautschnig force-pushed the symbol_exprt-concurrency branch from 0c566ef to 5a50186 Compare January 21, 2019 18:10
@tautschnig
Copy link
Collaborator Author

Use optionalt instead?

Indeed much better, done.

…f symbol_exprt

The implementation here is highly incomplete, in particular those symbols are
never set. If at some future date the implementation is completed then the type
of those members might be changed again.
@tautschnig tautschnig force-pushed the symbol_exprt-concurrency branch from 5a50186 to 0ee3175 Compare January 21, 2019 20:46
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 0ee3175).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98090521

@tautschnig tautschnig merged commit 893d970 into diffblue:develop Jan 23, 2019
@tautschnig tautschnig deleted the symbol_exprt-concurrency branch January 23, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants