array_of_exprt API #4371
Merged
array_of_exprt API #4371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Mar 12, 2019
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
martin-cs,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
approved these changes
Mar 12, 2019
src/util/std_expr.h
Outdated
| DEPRECATED("use array_of_exprt(what, type) instead") | ||
| array_of_exprt():unary_exprt(ID_array_of) | ||
| { | ||
| } |
There was a problem hiding this comment.
I guess I don't need to repeat myself.
allredj
reviewed
Mar 12, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 1c8972d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/104123062
peterschrammel
approved these changes
Mar 18, 2019
martin-cs
approved these changes
Mar 21, 2019
kroening
force-pushed
the
array_of_exprt_API
branch
from
1c8972d to
d337735
Compare
allredj
reviewed
Mar 23, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: d337735).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105521135
tautschnig
changed the title
tautschnig
changed the title
kroening
force-pushed
the
array_of_exprt_API
branch
from
d337735 to
728a231
Compare
allredj
reviewed
Mar 24, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 728a231).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105595168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.