struct_exprt API [do not merge before 2019-07-12] #4368
Conversation
kroening
commented
Mar 12, 2019
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
| DEPRECATED("use refined_string_exprt(length, content, type) instead") | ||
| refined_string_exprt() : struct_exprt() | ||
| { | ||
| } |
There was a problem hiding this comment.
This has only been marked as deprecated on 12 Jan 2019.
There was a problem hiding this comment.
Yes; however, I doubt it ever had any external user at all, given how specific it is to the string refiner.
| DEPRECATED("use struct_exprt(component_name, value, type) instead") | ||
| struct_exprt() : multi_ary_exprt(ID_struct) | ||
| { | ||
| } |
There was a problem hiding this comment.
Do we apply a 6-months rule?
There was a problem hiding this comment.
I would say it really depends on how much it inconveniences others. This one is a bit risky, since structs are pretty common. On the other hand, it's likely easy to fix.
There was a problem hiding this comment.
Well, something in this PR does seem to break building TG, so clearly one of the constructors is being used externally. (#3768 does take care of removing all of them, but is marked as do-not-merge-before-end-of-March.)
There was a problem hiding this comment.
That might well be a reasonable indicator. Let's wait with this one, and I'll merge #4367.
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 48a93a0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/104062318
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
tautschnig
changed the title
tautschnig
changed the title
kroening
force-pushed
the
struct_exprt_API
branch
from
48a93a0 to
15de885
Compare
tautschnig
changed the title
kroening
force-pushed
the
struct_exprt_API
branch
from
15de885 to
73a5d32
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 73a5d32).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105606677
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
|
Noting the do-not-merge-before has expired |
This has no users.
This has no users and has been deprecated since 2018-09-21.
kroening
force-pushed
the
struct_exprt_API
branch
from
7662d52 to
1cbd476
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 1cbd476).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122962820
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
