Skip to content

struct_exprt API [do not merge before 2019-07-12] #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2019
Merged

struct_exprt API [do not merge before 2019-07-12] #4368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a933933
remove refined_string_exprt constructor
Mar 12, 2019
e039c1e
remove deprecated struct_exprt constructor
Mar 12, 2019
1cbd476
fix deprecation message for struct_exprt
Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/util/std_expr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,14 +1751,7 @@ inline union_exprt &to_union_expr(exprt &expr)
class struct_exprt : public multi_ary_exprt
{
public:
DEPRECATED(
SINCE(2018, 9, 21, "use struct_exprt(component_name, value, type) instead"))
struct_exprt() : multi_ary_exprt(ID_struct)
{
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we apply a 6-months rule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it really depends on how much it inconveniences others. This one is a bit risky, since structs are pretty common. On the other hand, it's likely easy to fix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, something in this PR does seem to break building TG, so clearly one of the constructors is being used externally. (#3768 does take care of removing all of them, but is marked as do-not-merge-before-end-of-March.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might well be a reasonable indicator. Let's wait with this one, and I'll merge #4367.


DEPRECATED(
SINCE(2019, 1, 12, "use struct_exprt(component_name, value, type) instead"))
DEPRECATED(SINCE(2019, 1, 12, "use struct_exprt(operands, type) instead"))
explicit struct_exprt(const typet &_type) : multi_ary_exprt(ID_struct, _type)
{
}
Expand Down
9 changes: 0 additions & 9 deletions src/util/string_expr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,6 @@ inline const array_string_exprt &to_array_string_expr(const exprt &expr)
class refined_string_exprt : public struct_exprt
{
public:
DEPRECATED(SINCE(
2019,
1,
12,
"use refined_string_exprt(length, content, type) instead"))
refined_string_exprt() : struct_exprt()
{
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has only been marked as deprecated on 12 Jan 2019.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; however, I doubt it ever had any external user at all, given how specific it is to the string refiner.


refined_string_exprt(
const exprt &_length,
const exprt &_content,
Expand Down