Skip to content

Add an identifier-based lookup to constant_propagator_is_constantt [blocks: #3768] #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

This avoid the workaround of constructing a symbol_exprt without proper type
just for the sake of a lookup.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This avoid the workaround of constructing a symbol_exprt without proper type
just for the sake of a lookup.
@tautschnig tautschnig force-pushed the symbol_exprt-constant-propagator branch from 6dbf798 to 4455fb5 Compare January 21, 2019 14:32
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 4455fb5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98051548

@tautschnig tautschnig merged commit 9ceb95b into diffblue:develop Jan 21, 2019
@tautschnig tautschnig deleted the symbol_exprt-constant-propagator branch January 21, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants