Skip to content

Release nchs_mortality to production #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 95 commits into from
Dec 7, 2020
Merged

Release nchs_mortality to production #605

merged 95 commits into from
Dec 7, 2020

Conversation

korlaxxalrok
Copy link
Contributor

@korlaxxalrok korlaxxalrok commented Dec 7, 2020 •
edited
Loading

Description

Sends nchs_mortality to production!

In addition to the config that had already been placed on staging, there was
a fix that @eujing submitted recently of a2c7709.

Fixes

chinandrew and others added 30 commits November 20, 2020 14:26
@chinandrew
Get CHC to pass pydocstyle
7f087c3
@chinandrew
Add to makefile
a5223a1
@chinandrew
Get utils to pass pydocstyle
e816a30
@chinandrew
Get quidel_covidtest to pass pydocstyle
0374860
@chinandrew
Add pydocstyle to makefile
44eba98
@chinandrew
Correct makefile
44b4754
@chinandrew
Get quidel to pass pydocstyle
ac86ad8
@JedGrabman
Check for duplicate rows
5d9929d
@JedGrabman
Update plans.md to remove duplicate rows task
2545dce
@sgsmob
move parameter checking to be separate from other validation
cddfb38
@sgsmob
remove vestigial checks
9794653
@sgsmob
refactor of validate into a report
e0a29b8
@sgsmob
documentation of report
3938f85
@sgsmob
plug report logic into the running
51840c1
@sgsmob
adding pylintrc to validator package
08b8446
@sgsmob
pylint compliance
c7d1872
@sgsmob
add pylintrc
76c043f
@JedGrabman
Test Fix and Documentation Update
0ae148e 
- Update params for duplicate rows check
- Add duplicate rows to current checks section of PLANS.md
@korlaxxalrok
Add:
a9ba2ba 
- nchs_mortality prod params template
- New var and vault pointer
- nchs_mortality token to vault file
@sgsmob
refactor of validator for lint compliance
02692f9
@sgsmob
change order of super().__init__() call to preserve error function me…
cc34365 
…ssages
@sgsmob
trailing newline to pylintrc
f9e9900
@sgsmob
add TODO for last lint error
feafbed
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
727fe7a 
…o validator
@sgsmob
get validation pylint compliant
f6653aa
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
49bc1b2 
…o validator
@sgsmob
Merge branch 'validator' into validation_report
ec9cc20
@sgsmob
fix bug with missing argument to refactored function
48b75a8
@sgsmob
tests for utils
331dd15
@sgsmob
constants capitalization
29c2f12
korlaxxalrok and others added 25 commits December 3, 2020 13:41
@korlaxxalrok
Add step to Jenkinsfile, update file name
ef74971
@korlaxxalrok
Add specific remote user for this playbook
787c28a
@krivard
Merge pull request #596 from cmu-delphi/sircal/add-new-signals
16b5532 
SirCAL default config: Update signals list and max ages
@krivard
Merge pull request #595 from cmu-delphi/chng-time
3beda49 
Timezone issue described in #593
@krivard
Merge pull request #578 from sgsmob/validator
7fb09b6 
Make validation class pass the linter
@korlaxxalrok @krivard
Update ansible/templates/staging-api-match-list.j2
e01ac36 
Co-authored-by: Katie Mazaitis <[email protected]>
@korlaxxalrok
Update signal list
659e19a
@korlaxxalrok
Accept changes
3f1571e
@korlaxxalrok
Merge pull request #599 from cmu-delphi/add-ansible-to-set-api-match-…
df6e13b 
…list

Add Ansible and Jenkins necessities for deploying the staging api proxy signal match list
@korlaxxalrok
Update Jenkinsfile, add shell wrapper for Ansible playbook
ff005e8
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
7296aa8 
…o validation_report
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
7ef8f0a 
…o validator_combos
@krivard
Merge pull request #602 from cmu-delphi/fix-staging-api-deploy
723b75c 
Update Jenkinsfile, add shell wrapper for Ansible playbook
@eujing
Fix daily archive differ removing None files
a2c7709
@korlaxxalrok
Fix file permissions
65d7d53
@sgsmob
change name of unsuppressed errors
4409fd8
@sgsmob
change polarity of if/else to be positive
fabb50b
@krivard
Merge pull request #604 from cmu-delphi/fix-staging-api-deploy
9e3b957 
Fix file permissions
@krivard
Merge pull request #588 from sgsmob/validator_combos
82fe76d 
Only iterate over valid geo x signal combos in validation
@krivard
Merge pull request #603 from cmu-delphi/fix-nchs_mortality
e1546d9 
NCHS fix removing None files
@sgsmob
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
be1750a 
…o validation_report
@sgsmob
add_raised_warning documentation
27c3a79
@sgsmob
duplicate rows to use report
da71d08
@sgsmob
tests for reports
a8ca165
@krivard
Merge pull request #589 from sgsmob/validation_report
acf2aef 
Introduce a "validation report" into the validation suite
@korlaxxalrok korlaxxalrok requested a review from krivard December 7, 2020 21:20
@krivard
Copy link
Contributor

krivard commented Dec 7, 2020

Conveniently this will also release CHNG-CLI to prod, which I was about to do anyway.

krivard
krivard approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have exhaustively scanned through looking for gremlins and found none, so I think we're good to go 👍

@krivard
Copy link
Contributor

krivard commented Dec 7, 2020

Other things this will release:

  • pydocstyle compliance
  • proxy filters for staging
  • quidel lint compliance
  • validator package

@korlaxxalrok korlaxxalrok merged commit 8013c4e into prod Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@korlaxxalrok @krivard @chinandrew @JedGrabman @sgsmob @rumackaaron @eujing