NCHS fix removing None files #603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When doing archive diffing at the daily level and the daily_cache has actually been populated, we may get empty diffs for files that did not change, and these return a None instead of a file path.
The current code might try to remove these None objects as so:
This PR updates the tests to make sure this case gets tested, and updates the code to ensure we do not try to remove None objects.
Changelog
Itemize code/test/documentation changes and files added/removed.
delphi_nchs_mortality/archive_diffs.py
: Check for None diff files.tests/conftest.py
: Populate the test daily_cache directory with some files to test empty diffs.tests/test_data/weekly_202025_state_wip_deaths_covid_incidence_prop.csv
: File that should have no diff from what is generated.Fixes