Introduce a "validation report" into the validation suite #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o validation_report
sgsmob
requested review from
a team and
chinandrew
and removed request for
a team
chinandrew
reviewed
Dec 4, 2020
validator/delphi_validator/report.py
Outdated
Comment on lines
27
to
28
| suppressed_errors: List[Exception] | ||
| Errors raised from validation failures not found in `self.errors_to_suppress` |
There was a problem hiding this comment.
Should this be unsuppressed errors? Since it's errors that are not in the ignore list.
chinandrew
reviewed
Dec 4, 2020
| """ | ||
| self.raised_warnings.append(warning) | ||
|
|
||
| def __str__(self): |
There was a problem hiding this comment.
Add a test that this formats to what we expect
There was a problem hiding this comment.
Added tests for the whole report class
…o validation_report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a "validation report" object to the validation suite. This report handles the aggregation, printing, and interpretation of the errors raised by the various validation checks.
This not only separates the logic of aggregating the errors from the code that performs the checks but also should allow us to split out the validation checks into separate classes, using the report as an interface between them.
This includes changes introduced in #578 so it should not be reviewed until after that is merged.
Changelog
delphi_validation.report.ValidationReportto track the results of validationValidationReport