fix: support estimator output path parameterization #3108

jerrypeng7773 · 2022-05-13T20:28:28Z

Issue #, if available:

Description of changes:

support the parameterization of the output_path for estimator.

Testing done:

unit test

Merge Checklist

x Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]>

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]>

…ws#2950) Co-authored-by: Payton Staub <[email protected]>

…ws#2971)

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]>

sagemaker-bot · 2022-05-13T20:50:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f43dd91
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-13T20:51:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f43dd91
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-05-13T20:51:56Z

Codecov Report

Merging #3108 (f43dd91) into master (8c52f1b) will increase coverage by 0.00%.
The diff coverage is 85.71%.

❗ Current head f43dd91 differs from pull request most recent head e315711. Consider uploading reports for the commit e315711 to get more accurate results

@@           Coverage Diff           @@
##           master    #3108   +/-   ##
=======================================
  Coverage   89.56%   89.57%           
=======================================
  Files         200      200           
  Lines       17284    17288    +4     
=======================================
+ Hits        15481    15485    +4     
  Misses       1803     1803

Impacted Files	Coverage Δ
src/sagemaker/estimator.py	`91.37% <85.71%> (-0.10%)`	⬇️
src/sagemaker/session.py	`71.03% <0.00%> (+0.07%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c52f1b...e315711. Read the comment docs.

sagemaker-bot · 2022-05-13T21:16:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f43dd91
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-13T21:21:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f43dd91
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aws#2980) Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Mohamed Ali Jamaoui <[email protected]> Co-authored-by: ci <ci> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: sreedes <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Miyoung <[email protected]> Co-authored-by: Ameen Khan <[email protected]> Co-authored-by: Zhankui Lu <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Xiaoguang Chen <[email protected]> Co-authored-by: Jonathan Guinegagne <[email protected]> Co-authored-by: Zhankui Lu <[email protected]> Co-authored-by: Yifei Zhu <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Xinghan Chen <[email protected]> Co-authored-by: Tulio Casagrande <[email protected]> Co-authored-by: HappyAmazonian <[email protected]>

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Miyoung <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]>

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: EC2 Default User <[email protected]> Co-authored-by: Miyoung <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]>

Co-authored-by: Ahsan Khan <[email protected]>

Co-authored-by: Mufaddal Rohawala <[email protected]>

* feature: Add support for TF 2.7 and TF 2.8 * Correct TF 2.7 patch version used in tests * Correct TF 2.7 patch version for SMDDP TF versions * Only add entries for TF 2.8 * Fix test options for TF 2.8 for fw_utils * Update tensorflow.json Co-authored-by: Mufaddal Rohawala <[email protected]>

* change: update code to get commit_id in codepipeline (aws#2961) * feature: Data Serializer (aws#2956) * change: reorganize test files for workflow (aws#2960) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> * feature: TensorFlow 2.4 for Neo (aws#2861) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950) Co-authored-by: Payton Staub <[email protected]> * fix: Style update in DataSerializer (aws#2962) * documentation: smddp doc update (aws#2968) * fix: container env generation for S3 URI and add test for the same (aws#2971) * documentation: update sagemaker training compiler docstring (aws#2969) * feat: Python 3.9 for readthedocs (aws#2973) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

…#3040) Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: HappyAmazonian <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Madhubalasri B <[email protected]> Co-authored-by: evakravi <[email protected]>

Co-authored-by: Shreya Pandit <[email protected]>

…3064) Co-authored-by: Shreya Pandit <[email protected]>

Co-authored-by: Basil Beirouti <[email protected]>

Co-authored-by: Shreya Pandit <[email protected]>

Co-authored-by: Navin Soni <[email protected]>

sagemaker-bot · 2022-05-13T21:48:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f43dd91
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-13T21:49:59Z

tests/unit/sagemaker/workflow/test_utils.py

+    for file in tree:
+        try:
+            os.makedirs(os.path.join(root, os.path.dirname(file)))
+        except:  # noqa: E722 Using bare except because p2/3 incompatibility issues.


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:50:00Z

tests/integ/sagemaker/workflow/test_workflow.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:50:00Z

tests/integ/sagemaker/workflow/test_processing_steps.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:50:00Z

src/sagemaker/jumpstart/notebook_utils.py

+    return sorted(list(model_id_version_set), key=cmp_to_key(_compare_model_version_tuples))
+
+
+def _generate_jumpstart_model_versions(  # pylint: disable=redefined-builtin


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

This function contains 64 lines of code, not including blank lines or lines with only comments, Python punctuation characters, identifiers, or literals. By comparison, 99% of the functions in the CodeGuru reference dataset contain fewer lines of code. Large functions might be difficult to read and have logic that is hard to understand and test. We recommend that you simplify this function or break it into multiple functions.

sagemaker-bot · 2022-05-13T21:50:00Z

tests/integ/sagemaker/workflow/test_callback_steps.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:50:02Z

tests/integ/sagemaker/workflow/test_training_steps.py

+        finally:
+            try:
+                pipeline.delete()
+            except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:50:02Z

tests/integ/sagemaker/workflow/test_workflow.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:50:02Z

tests/integ/sagemaker/workflow/test_model_create_and_registration.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:50:02Z

src/sagemaker/workflow/utilities.py

@@ -48,13 +53,82 @@ def hash_file(path: str) -> str:
    Returns:
        str: The MD5 hash of the file.
    """
-    BUF_SIZE = 65536  # read in 64KiB chunks
+    return _hash_file(path, hashlib.md5()).hexdigest()


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

The hashing algorithm you are using is unsecure and might lead to cryptographic vulnerabilities. Learn more. Use a more secure hashing algorithm when creating message digests using hashlib. For example, use SHA224, SHA256, SHA384, or SHA512.

Learn more

sagemaker-bot · 2022-05-13T21:50:02Z

tests/integ/sagemaker/workflow/test_workflow.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:52:07Z

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

sagemaker-bot · 2022-05-13T21:52:08Z

tests/integ/sagemaker/workflow/test_training_steps.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:52:08Z

tests/integ/sagemaker/workflow/test_lambda_steps.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:52:08Z

tests/integ/sagemaker/workflow/test_processing_steps.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:52:08Z

tests/integ/sagemaker/workflow/test_callback_steps.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:52:08Z

src/sagemaker/jumpstart/notebook_utils.py

+            f"{(model_manifest.model_id, model_manifest.version)}."
+        )
+
+    if len(unrecognized_keys) > 0:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

To check if a container or sequence (string, list, tuple) is empty, use if not val. Do not compare its length using if len(val) == 0 or if len(val) > 0

Learn more

sagemaker-bot · 2022-05-13T21:52:09Z

tests/integ/sagemaker/workflow/test_processing_steps.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:52:09Z

tests/integ/sagemaker/workflow/test_model_create_and_registration.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:52:09Z

tests/data/xgboost_abalone/inference.py

+    Deserialize and return fitted model.
+    """
+    model_file = "xgboost-model"
+    booster = pkl.load(open(os.path.join(model_dir, model_file), "rb"))


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Pickle and modules that wrap it can be unsafe when used to deserialize untrusted data, possible security issue. https://bandit.readthedocs.io/en/latest/blacklists/blacklist_calls.html#b301-pickle

sagemaker-bot · 2022-05-13T21:52:09Z

tests/integ/sagemaker/workflow/test_workflow.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:52:09Z

tests/integ/sagemaker/workflow/test_lambda_steps.py

+    finally:
+        try:
+            pipeline.delete()
+        except Exception:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Try, Except, Pass detected. https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html

sagemaker-bot · 2022-05-13T21:54:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e315711
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-13T22:20:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e315711
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-13T22:21:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e315711
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-13T22:22:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e315711
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-13T22:36:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e315711
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni and others added 10 commits March 1, 2022 14:18

change: update code to get commit_id in codepipeline (aws#2961)

f166b60

feature: Data Serializer (aws#2956)

086258d

change: reorganize test files for workflow (aws#2960)

a39b750

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]>

feature: TensorFlow 2.4 for Neo (aws#2861)

28fd737

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]>

fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (a…

20df3d7

…ws#2950) Co-authored-by: Payton Staub <[email protected]>

fix: Style update in DataSerializer (aws#2962)

b9f90dc

documentation: smddp doc update (aws#2968)

6db3774

fix: container env generation for S3 URI and add test for the same (a…

d610bfb

…ws#2971)

documentation: update sagemaker training compiler docstring (aws#2969)

169dffd

ci and others added 15 commits May 13, 2022 14:31

prepare release v2.78.0

3baf513

update development version to v2.78.1.dev0

c0c2b9c

feature: Inferentia Neuron support for HuggingFace (aws#2976)

588dd69

prepare release v2.79.0

80f3054

update development version to v2.79.1.dev0

a57ad9d

fix: jumpstart docs network isolation (aws#2989)

f6689a3

feature: AutoGluon 0.3.2 and 0.4.0 image_uris (aws#2991)

4440b5b

fix: gpu integs CapacityError - fallback to available compute (aws#3004)

c87a887

Co-authored-by: Ahsan Khan <[email protected]>

feature: Add support for TF 2.6.3 (aws#3006)

f49061b

Co-authored-by: Mufaddal Rohawala <[email protected]>

feature: TF242 ioc support (aws#2982)

a629f2f

Co-authored-by: Mufaddal Rohawala <[email protected]>

ci and others added 18 commits May 13, 2022 14:31

update development version to v2.88.2.dev0

39eb67d

fix: Automl integ describe job check (aws#3088)

38ce6f7

prepare release v2.88.2

e4ae2ac

update development version to v2.88.3.dev0

4a6a0bd

Feat/jumpstart model table update (aws#3087)

ae25f59

Co-authored-by: Shreya Pandit <[email protected]>

deprecate: Remove deprecated argument s3_data_distribution_type (aws#…

8001ba7

…3064) Co-authored-by: Shreya Pandit <[email protected]>

prepare release v2.88.3

a10efe0

update development version to v2.88.4.dev0

ee86a54

feature: add validation specification (aws#3075)

4f4096b

Co-authored-by: Basil Beirouti <[email protected]>

fix: repack model locally when local_code local mode (aws#3094)

4388782

documentation: smdmp 1.8.1 release note (aws#3085)

3694bef

Co-authored-by: Shreya Pandit <[email protected]>

feature: Add PT 1.11 support (aws#3097)

16abd93

prepare release v2.89.0

44f5d09

update development version to v2.89.1.dev0

15a78b1

fix: update setup.py to add minimum python requirement of 3.6 (aws#3105)

500af4c

Co-authored-by: Navin Soni <[email protected]>

feature: Add ModelStep for SageMaker Model Building Pipeline (aws#3076)

9014064

support estimator output path parameterization

e315711

jerrypeng7773 force-pushed the master branch from f43dd91 to e315711 Compare May 13, 2022 21:31

jerrypeng7773 changed the title ~~support estimator output path parameterization~~ fix: support estimator output path parameterization May 13, 2022

jerrypeng7773 closed this May 13, 2022

sagemaker-bot reviewed May 13, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: support estimator output path parameterization #3108

fix: support estimator output path parameterization #3108

jerrypeng7773 commented May 13, 2022

sagemaker-bot commented May 13, 2022

sagemaker-bot commented May 13, 2022

codecov-commenter commented May 13, 2022 •

edited

Loading

sagemaker-bot commented May 13, 2022

sagemaker-bot commented May 13, 2022

sagemaker-bot commented May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot commented May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot May 13, 2022

sagemaker-bot commented May 13, 2022

sagemaker-bot commented May 13, 2022

sagemaker-bot commented May 13, 2022

sagemaker-bot commented May 13, 2022

sagemaker-bot commented May 13, 2022

		return sorted(list(model_id_version_set), key=cmp_to_key(_compare_model_version_tuples))


		def _generate_jumpstart_model_versions( # pylint: disable=redefined-builtin

fix: support estimator output path parameterization #3108

fix: support estimator output path parameterization #3108

Conversation

jerrypeng7773 commented May 13, 2022

Merge Checklist

General

Tests

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

codecov-commenter commented May 13, 2022 • edited Loading

Codecov Report

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sagemaker-bot commented May 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

sagemaker-bot commented May 13, 2022

AWS CodeBuild CI Report

codecov-commenter commented May 13, 2022 •

edited

Loading