change: reorganize test files for workflow #2960

qidewenwhen · 2022-02-25T20:56:56Z

Description of changes:
As more and more features are adding to the SageMaker Pipeline workflow, its integration test file test_workflow.py keeps growing and becomes too large to manage. There're a few workflow features with separate integration test files e.g. test_quality_check_steps.py. test_clarify_check_steps.py etc. However, such workflow integ test files are not properly organized as they're all directly put under the integ/ directory.

This PR re-organizes integ test files for SM Pipeline workflow, which:

Separate integ test files according to Pipeline step types and relocate tests defined in test_workflows.py accordingly
Organize all workflow related integ tests under directory of integ/sagemaker/workflow/ similar to the pattern for workflow unit tests

Note: No new tests are added. This PR moves existing Pipeline workflow integ tests to proper directories.

Testing done: N/A

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2022-02-25T21:13:25Z

Codecov Report

Merging #2960 (cbfca45) into dev (26b984a) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##              dev    #2960      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.01%     
==========================================
  Files         196      196              
  Lines       16548    16563      +15     
==========================================
+ Hits        14863    14875      +12     
- Misses       1685     1688       +3

Impacted Files	Coverage Δ
src/sagemaker/serializers.py	`92.96% <80.00%> (-1.73%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b984a...cbfca45. Read the comment docs.

sagemaker-bot · 2022-02-25T21:14:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 62d8c26
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-25T21:15:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 62d8c26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-25T21:15:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5f2e01d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-25T21:26:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 62d8c26
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-25T21:51:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5f2e01d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-25T22:03:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5f2e01d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-25T22:17:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8696ba5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-25T22:51:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5f2e01d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-25T23:13:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8696ba5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-26T00:43:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8696ba5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tests/integ/sagemaker/workflow/test_workflow.py

sagemaker-bot · 2022-02-28T18:09:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 01f11bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-28T18:45:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 01f11bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-28T19:59:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 01f11bd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-28T20:56:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cbfca45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-28T21:47:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cbfca45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-28T21:49:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cbfca45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-28T23:46:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cbfca45
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-01T20:05:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cbfca45
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-01T23:06:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cbfca45
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-01T23:33:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cbfca45
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-02T06:34:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cbfca45
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-03T00:47:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cbfca45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]>

* change: update code to get commit_id in codepipeline (#2961) * feature: Data Serializer (#2956) * change: reorganize test files for workflow (#2960) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> * feature: TensorFlow 2.4 for Neo (#2861) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (#2950) Co-authored-by: Payton Staub <[email protected]> * fix: Style update in DataSerializer (#2962) * documentation: smddp doc update (#2968) * fix: container env generation for S3 URI and add test for the same (#2971) * documentation: update sagemaker training compiler docstring (#2969) * feat: Python 3.9 for readthedocs (#2973) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

* change: update code to get commit_id in codepipeline (aws#2961) * feature: Data Serializer (aws#2956) * change: reorganize test files for workflow (aws#2960) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> * feature: TensorFlow 2.4 for Neo (aws#2861) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950) Co-authored-by: Payton Staub <[email protected]> * fix: Style update in DataSerializer (aws#2962) * documentation: smddp doc update (aws#2968) * fix: container env generation for S3 URI and add test for the same (aws#2971) * documentation: update sagemaker training compiler docstring (aws#2969) * feat: Python 3.9 for readthedocs (aws#2973) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]>

* change: update code to get commit_id in codepipeline (aws#2961) * feature: Data Serializer (aws#2956) * change: reorganize test files for workflow (aws#2960) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> * feature: TensorFlow 2.4 for Neo (aws#2861) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950) Co-authored-by: Payton Staub <[email protected]> * fix: Style update in DataSerializer (aws#2962) * documentation: smddp doc update (aws#2968) * fix: container env generation for S3 URI and add test for the same (aws#2971) * documentation: update sagemaker training compiler docstring (aws#2969) * feat: Python 3.9 for readthedocs (aws#2973) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

fix: jumpstart model table (aws#2954)

6670e30

qidewenwhen force-pushed the organize branch from 62d8c26 to 5f2e01d Compare February 25, 2022 21:04

qidewenwhen force-pushed the organize branch from 5f2e01d to 8696ba5 Compare February 25, 2022 21:55

qidewenwhen requested review from jerrypeng7773 and staubhp February 25, 2022 22:13

navinsoni and others added 3 commits February 25, 2022 21:43

change: update code to get commit_id in codepipeline (aws#2961)

4ce6623

feature: Data Serializer (aws#2956)

5c64e6c

change: Reorganize integ test files for workflow

01f11bd

qidewenwhen force-pushed the organize branch from 8696ba5 to 01f11bd Compare February 28, 2022 17:45

jerrypeng7773 approved these changes Feb 28, 2022

View reviewed changes

tests/integ/sagemaker/workflow/test_workflow.py Show resolved Hide resolved

fix: Remove unneeded __init__ file

cbfca45

shreyapandit approved these changes Feb 28, 2022

View reviewed changes

qidewenwhen removed the request for review from staubhp February 28, 2022 23:11

shreyapandit force-pushed the dev branch from 5c64e6c to 086258d Compare March 1, 2022 22:37

navinsoni approved these changes Mar 1, 2022

View reviewed changes

shreyapandit changed the title ~~change: reorganize integ test files for workflow~~ change: reorganize test files for workflow Mar 3, 2022

shreyapandit merged commit a39b750 into aws:dev Mar 3, 2022

qidewenwhen deleted the organize branch March 4, 2022 18:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change: reorganize test files for workflow #2960

change: reorganize test files for workflow #2960

qidewenwhen commented Feb 25, 2022 •

edited

Loading

codecov-commenter commented Feb 25, 2022 •

edited

Loading

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 25, 2022

sagemaker-bot commented Feb 26, 2022

sagemaker-bot commented Feb 28, 2022

sagemaker-bot commented Feb 28, 2022

sagemaker-bot commented Feb 28, 2022

sagemaker-bot commented Feb 28, 2022

sagemaker-bot commented Feb 28, 2022

sagemaker-bot commented Feb 28, 2022

sagemaker-bot commented Feb 28, 2022

sagemaker-bot commented Mar 1, 2022

sagemaker-bot commented Mar 1, 2022

sagemaker-bot commented Mar 1, 2022

sagemaker-bot commented Mar 2, 2022

sagemaker-bot commented Mar 3, 2022

change: reorganize test files for workflow #2960

change: reorganize test files for workflow #2960

Conversation

qidewenwhen commented Feb 25, 2022 • edited Loading

Merge Checklist

General

Tests

codecov-commenter commented Feb 25, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 25, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 26, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 3, 2022

AWS CodeBuild CI Report

qidewenwhen commented Feb 25, 2022 •

edited

Loading

codecov-commenter commented Feb 25, 2022 •

edited

Loading