feature: TensorFlow 2.4 for Neo #2861

Qingzi-Lan · 2022-01-21T01:22:22Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-01-21T01:42:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ec72086
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan

unit tests failing. Can you check the logs?
ValueError: Unsupported neo-tensorflow version: None. You may need to upgrade your SDK version (pip install -U sagemaker) for newer neo-tensorflow versions. Supported neo-tensorflow version(s): 1.15.3, 2.4.2, 1.4.1, 1.5.0, 1.6.0, 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0, 2.4.2.

codecov-commenter · 2022-01-21T02:12:33Z

Codecov Report

Merging #2861 (6e5bc26) into dev (086258d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2861   +/-   ##
=======================================
  Coverage   89.80%   89.81%           
=======================================
  Files         196      196           
  Lines       16563    16563           
=======================================
+ Hits        14875    14876    +1     
+ Misses       1688     1687    -1

Impacted Files	Coverage Δ
src/sagemaker/session.py	`70.47% <0.00%> (+0.07%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086258d...6e5bc26. Read the comment docs.

sagemaker-bot · 2022-01-21T02:26:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ec72086
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-21T02:28:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ec72086
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T20:23:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e3e38a8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T20:26:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e3e38a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aker-python-sdk into adding-tf24-ioc

sagemaker-bot · 2022-02-23T20:39:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 67ff93f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T20:41:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e3e38a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T20:41:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 67ff93f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T20:50:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 67ff93f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Qingzi-Lan · 2022-02-23T22:24:15Z

unit tests failing. Can you check the logs? ValueError: Unsupported neo-tensorflow version: None. You may need to upgrade your SDK version (pip install -U sagemaker) for newer neo-tensorflow versions. Supported neo-tensorflow version(s): 1.15.3, 2.4.2, 1.4.1, 1.5.0, 1.6.0, 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0, 2.4.2.

images just got fully released last week. can you check the PR again. Thanks

sagemaker-bot · 2022-02-28T18:54:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f5cb343
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-28T18:57:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f5cb343
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Qingzi-Lan · 2022-02-28T19:14:15Z

@ahsan-z-khan can you help me find the failed test case log?

Qingzi-Lan · 2022-03-01T23:47:20Z

Hi @shreyapandit, I saw the sdk-pr test is still failing without log. Can you check it again. thanks

sagemaker-bot · 2022-03-02T18:47:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f5cb343
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Qingzi-Lan · 2022-03-02T19:51:50Z

@shreyapandit all tests passed this time. can you please review it.

navinsoni

@Qingzi-Lan Can you please rebase this PR so that it has only your changes

Qingzi-Lan · 2022-03-02T20:16:44Z

@Qingzi-Lan Can you please rebase this PR so that it has only your changes

@navinsoni, the change was pushed by @shreyapandit from dev branch. should I revert them back and only have my own change?

shreyapandit · 2022-03-02T20:58:22Z

Hi @Qingzi-Lan , I updated your branch with dev earlier. Since we have synced dev again with release commits from master, you would need to update your branch with dev again. You can do so by performing a rebase with dev. ie git rebase dev and with that you should be all set to go

…aker-python-sdk into adding-tf24-ioc

Qingzi-Lan · 2022-03-02T21:16:52Z

Hi @Qingzi-Lan , I updated your branch with dev earlier. Since we have synced dev again with release commits from master, you would need to update your branch with dev again. You can do so by performing a rebase with dev. ie git rebase dev and with that you should be all set to go

just rebased, want to double check, to contribute to SDK, should I start on master or dev branch?

sagemaker-bot · 2022-03-02T21:26:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6e5bc26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-02T21:28:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6e5bc26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-02T21:40:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6e5bc26
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Qingzi-Lan · 2022-03-02T22:14:50Z

@shreyapandit please review it again, all checks passes

shreyapandit · 2022-03-03T01:20:04Z

Hi @Qingzi-Lan , I updated your branch with dev earlier. Since we have synced dev again with release commits from master, you would need to update your branch with dev again. You can do so by performing a rebase with dev. ie git rebase dev and with that you should be all set to go

just rebased, want to double check, to contribute to SDK, should I start on master or dev branch?

You should start from dev, which I think you did. We just have a peculiar process where upon release there are some extra commits on master that made by CI that need to be brought back onto dev, which changes branch history and hence the rebase is needed again. We are working to simplify this so that it won't be as involved in the future.

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]>

* change: update code to get commit_id in codepipeline (#2961) * feature: Data Serializer (#2956) * change: reorganize test files for workflow (#2960) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> * feature: TensorFlow 2.4 for Neo (#2861) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (#2950) Co-authored-by: Payton Staub <[email protected]> * fix: Style update in DataSerializer (#2962) * documentation: smddp doc update (#2968) * fix: container env generation for S3 URI and add test for the same (#2971) * documentation: update sagemaker training compiler docstring (#2969) * feat: Python 3.9 for readthedocs (#2973) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

* change: update code to get commit_id in codepipeline (aws#2961) * feature: Data Serializer (aws#2956) * change: reorganize test files for workflow (aws#2960) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> * feature: TensorFlow 2.4 for Neo (aws#2861) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950) Co-authored-by: Payton Staub <[email protected]> * fix: Style update in DataSerializer (aws#2962) * documentation: smddp doc update (aws#2968) * fix: container env generation for S3 URI and add test for the same (aws#2971) * documentation: update sagemaker training compiler docstring (aws#2969) * feat: Python 3.9 for readthedocs (aws#2973) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]>

* change: update code to get commit_id in codepipeline (aws#2961) * feature: Data Serializer (aws#2956) * change: reorganize test files for workflow (aws#2960) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> * feature: TensorFlow 2.4 for Neo (aws#2861) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950) Co-authored-by: Payton Staub <[email protected]> * fix: Style update in DataSerializer (aws#2962) * documentation: smddp doc update (aws#2968) * fix: container env generation for S3 URI and add test for the same (aws#2971) * documentation: update sagemaker training compiler docstring (aws#2969) * feat: Python 3.9 for readthedocs (aws#2973) Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Dewen Qi <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

update tf24 ioc config

ec72086

ahsan-z-khan changed the title ~~update TF24 Neo IOC SDK~~ feature: TF2.4 for Neo Jan 21, 2022

ahsan-z-khan changed the title ~~feature: TF2.4 for Neo~~ feature: TensorFlow 2.4 for Neo Jan 21, 2022

ahsan-z-khan suggested changes Jan 21, 2022

View reviewed changes

BasilBeirouti force-pushed the dev branch from 814dd3d to 70308b1 Compare January 24, 2022 20:10

jeniyat force-pushed the dev branch 3 times, most recently from f5e6849 to 34b07c0 Compare January 29, 2022 23:28

mufaddal-rohawala force-pushed the dev branch 3 times, most recently from 96c01d7 to c437191 Compare February 5, 2022 00:08

jeniyat added the needs contributor changes label Feb 7, 2022

jeniyat force-pushed the dev branch from 9d612a7 to bb7563f Compare February 7, 2022 23:40

navinsoni force-pushed the dev branch from 3e68e14 to 668359f Compare February 22, 2022 02:34

BasilBeirouti force-pushed the dev branch from 0e4fd55 to 26b984a Compare February 23, 2022 02:20

Merge branch 'dev' into adding-tf24-ioc

e3e38a8

Qingzi-Lan added 2 commits February 23, 2022 12:27

udpate

d75bd08

Merge branch 'adding-tf24-ioc' of https://github.com/Qingzi-Lan/sagem…

67ff93f

…aker-python-sdk into adding-tf24-ioc

fix: jumpstart model table (aws#2954)

6670e30

shreyapandit force-pushed the dev branch from 5c64e6c to 086258d Compare March 1, 2022 22:37

shreyapandit requested review from navinsoni and shreyapandit March 2, 2022 18:43

navinsoni suggested changes Mar 2, 2022

View reviewed changes

Qingzi-Lan added 3 commits March 2, 2022 13:14

update tf24 ioc config

ceae93a

udpate

09904ad

Merge branch 'adding-tf24-ioc' of https://github.com/Qingzi-Lan/sagem…

6e5bc26

…aker-python-sdk into adding-tf24-ioc

shreyapandit approved these changes Mar 3, 2022

View reviewed changes

navinsoni approved these changes Mar 3, 2022

View reviewed changes

shreyapandit merged commit 28fd737 into aws:dev Mar 3, 2022

shreyapandit pushed a commit that referenced this pull request Mar 4, 2022

feature: TensorFlow 2.4 for Neo (#2861)

b1340e7

Co-authored-by: Ben Crabtree <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]>

Qingzi-Lan deleted the adding-tf24-ioc branch March 7, 2022 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: TensorFlow 2.4 for Neo #2861

feature: TensorFlow 2.4 for Neo #2861

Qingzi-Lan commented Jan 21, 2022

sagemaker-bot commented Jan 21, 2022

ahsan-z-khan left a comment

codecov-commenter commented Jan 21, 2022 •

edited

Loading

sagemaker-bot commented Jan 21, 2022

sagemaker-bot commented Jan 21, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

Qingzi-Lan commented Feb 23, 2022

sagemaker-bot commented Feb 28, 2022

sagemaker-bot commented Feb 28, 2022

Qingzi-Lan commented Feb 28, 2022

Qingzi-Lan commented Mar 1, 2022

sagemaker-bot commented Mar 2, 2022

Qingzi-Lan commented Mar 2, 2022

navinsoni left a comment

Qingzi-Lan commented Mar 2, 2022

shreyapandit commented Mar 2, 2022

Qingzi-Lan commented Mar 2, 2022

sagemaker-bot commented Mar 2, 2022

sagemaker-bot commented Mar 2, 2022

sagemaker-bot commented Mar 2, 2022

Qingzi-Lan commented Mar 2, 2022

shreyapandit commented Mar 3, 2022

feature: TensorFlow 2.4 for Neo #2861

feature: TensorFlow 2.4 for Neo #2861

Conversation

Qingzi-Lan commented Jan 21, 2022

Merge Checklist

General

Tests

sagemaker-bot commented Jan 21, 2022

AWS CodeBuild CI Report

ahsan-z-khan left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 21, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Jan 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

Qingzi-Lan commented Feb 23, 2022

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 28, 2022

AWS CodeBuild CI Report

Qingzi-Lan commented Feb 28, 2022

Qingzi-Lan commented Mar 1, 2022

sagemaker-bot commented Mar 2, 2022

AWS CodeBuild CI Report

Qingzi-Lan commented Mar 2, 2022

navinsoni left a comment

Choose a reason for hiding this comment

Qingzi-Lan commented Mar 2, 2022

shreyapandit commented Mar 2, 2022

Qingzi-Lan commented Mar 2, 2022

sagemaker-bot commented Mar 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 2, 2022

AWS CodeBuild CI Report

Qingzi-Lan commented Mar 2, 2022

shreyapandit commented Mar 3, 2022

codecov-commenter commented Jan 21, 2022 •

edited

Loading