Skip to content

fix: repack model locally when local_code local mode #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022

Conversation

mufaddal-rohawala
Copy link
Member

Issue #, if available:
#3031
#3084

Description of changes:
sagemaker.model.Model uploads data to S3 when repacking, regardless and despite of local mode settings being specific to use local_code.

Testing done:
Locally tested, added test for checking botosession.resource('s3') and botosession.client('s3') calls are not getting made.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: bccd37d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bccd37d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #3094 (bccd37d) into master (57d4763) will decrease coverage by 0.07%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
- Coverage   89.60%   89.52%   -0.08%     
==========================================
  Files        1043      199     -844     
  Lines       86746    17176   -69570     
==========================================
- Hits        77728    15377   -62351     
+ Misses       9018     1799    -7219     
Impacted Files Coverage Δ
src/sagemaker/model.py 91.90% <80.00%> (-0.27%) ⬇️
.../lib/python3.6/site-packages/sagemaker/__init__.py
...ython3.9/site-packages/sagemaker/local/entities.py
...thon3.6/site-packages/sagemaker/jumpstart/utils.py
.../lib/python3.7/site-packages/sagemaker/fw_utils.py
...ackages/sagemaker/async_inference/waiter_config.py
...python3.9/site-packages/sagemaker/sklearn/model.py
...ython3.7/site-packages/sagemaker/mxnet/defaults.py
...maker/cli/compatibility/v2/modifiers/predictors.py
....9/site-packages/sagemaker/jumpstart/exceptions.py
... and 835 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d4763...bccd37d. Read the comment docs.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: bccd37d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: bccd37d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: bccd37d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: bccd37d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@navinsoni navinsoni requested a review from shreyapandit May 6, 2022 17:08
@navinsoni navinsoni merged commit 8562ee2 into aws:master May 6, 2022
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants