feature: TF242 ioc support #2982

Qingzi-Lan · 2022-03-09T20:48:03Z

Description of changes:

update Tensorflow 2.4.2 ioc SDK support
add version aliases

Testing done:

build locally and tested on personal account Sagemaker studio

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-03-09T20:53:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ea54793
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-09T21:23:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5ca8c57
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-03-09T21:32:23Z

Codecov Report

Merging #2982 (dd4b5a1) into master (a387c4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2982   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         196      196           
  Lines       16610    16610           
=======================================
  Hits        14933    14933           
  Misses       1677     1677

Impacted Files	Coverage Δ
src/sagemaker/model.py	`92.11% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a387c4c...dd4b5a1. Read the comment docs.

sagemaker-bot · 2022-03-09T21:44:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ea54793
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-09T21:57:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5ca8c57
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-09T22:35:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5ca8c57
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-09T22:36:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ea54793
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-09T22:59:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ea54793
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-14T18:41:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 076f6f9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-14T19:40:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 076f6f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-14T20:07:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 076f6f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Qingzi-Lan · 2022-03-14T21:41:30Z

Hi @ahsan-z-khan, can you help me check on the failed testcase? Thanks

ahsan-z-khan · 2022-03-15T16:45:20Z

Hi @ahsan-z-khan, can you help me check on the failed testcase? Thanks

@Qingzi-Lan tests are failing due to capacity issues on p3. Not related to your changes.

sagemaker-bot · 2022-03-15T17:45:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 656f960
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Qingzi-Lan · 2022-03-15T18:51:02Z

Hi @ahsan-z-khan, can you help me check on the failed testcase? Thanks

@Qingzi-Lan tests are failing due to capacity issues on p3. Not related to your changes.

is there a way to quickly rerun one of the tests? and can we force merge it since it's not related to my change?

sagemaker-bot · 2022-03-15T19:01:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 656f960
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T17:38:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 34af8a8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T21:23:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5affbb4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T22:17:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5affbb4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T22:49:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 49dc59f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T23:30:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5affbb4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T23:30:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 49dc59f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T23:32:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b9d0e27
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T23:41:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 565af7c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T23:56:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 49dc59f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T23:57:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a496a7a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T00:10:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b9d0e27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T00:33:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a496a7a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T00:33:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 565af7c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T00:33:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 565af7c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T00:33:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a496a7a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T00:46:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b9d0e27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T23:54:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: dd4b5a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T00:30:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: dd4b5a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T00:33:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dd4b5a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T01:26:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: dd4b5a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Mufaddal Rohawala <[email protected]>

update TF242 ioc support

ea54793

lint

5ca8c57

Qingzi-Lan added 2 commits March 14, 2022 11:18

trigger test

7330099

revert trigger test

076f6f9

ahsan-z-khan approved these changes Mar 14, 2022

View reviewed changes

ahsan-z-khan approved these changes Mar 15, 2022

View reviewed changes

ahsan-z-khan changed the title ~~[Tensorflow] update TF242 ioc support~~ feature: TF242 ioc support Mar 15, 2022

Qingzi-Lan added 2 commits March 15, 2022 10:25

trigger test

ede040a

revert trigger test

656f960

mufaddal-rohawala approved these changes Mar 16, 2022

View reviewed changes

update test framework version

34af8a8

Qingzi-Lan added 2 commits March 16, 2022 10:53

update

223d4de

revert previous change

5657fd4

update

49dc59f

format

b9d0e27

Qingzi-Lan added 2 commits March 16, 2022 16:33

update

565af7c

format

a496a7a

ashishgupta023 approved these changes Mar 17, 2022

View reviewed changes

Merge branch 'master' into TF242-IOC-update

dd4b5a1

mufaddal-rohawala merged commit 0dd0350 into aws:master Mar 18, 2022

Qingzi-Lan deleted the TF242-IOC-update branch March 22, 2022 21:19

ahsan-z-khan pushed a commit to ahsan-z-khan/sagemaker-python-sdk that referenced this pull request Mar 23, 2022

feature: TF242 ioc support (aws#2982)

ea86e37

Co-authored-by: Mufaddal Rohawala <[email protected]>

Qingzi-Lan mentioned this pull request Mar 28, 2022

fix: IOC image version select issue #3021

Merged

9 tasks

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022

feature: TF242 ioc support (aws#2982)

a629f2f

Co-authored-by: Mufaddal Rohawala <[email protected]>

feature: TF242 ioc support #2982

feature: TF242 ioc support #2982

Conversation

Qingzi-Lan commented Mar 9, 2022

Merge Checklist

General

Tests

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

codecov-commenter commented Mar 9, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 14, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 14, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 14, 2022

AWS CodeBuild CI Report

Qingzi-Lan commented Mar 14, 2022

ahsan-z-khan commented Mar 15, 2022

sagemaker-bot commented Mar 15, 2022

AWS CodeBuild CI Report

Qingzi-Lan commented Mar 15, 2022

sagemaker-bot commented Mar 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

codecov-commenter commented Mar 9, 2022 •

edited

Loading