Fix for #2949. #2951

osdf · 2022-02-23T02:03:45Z

Extend the set of types that are not handled by json.dumps to elementary types.

Description of changes:

Testing done:
Local test.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…2935)

Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: HappyAmazonian <[email protected]>

Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Navin Soni <[email protected]>

) Co-authored-by: Shreya Pandit <[email protected]>

Co-authored-by: Dewen Qi <[email protected]>

Extend the set of types that are not handled by json.dumps to elementary types.

sagemaker-bot · 2022-02-23T02:15:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 88ac6c6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Fixing tests to reflect desired behaviour.

sagemaker-bot · 2022-02-23T02:29:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: dbdf106
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T02:51:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: dbdf106
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T02:51:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 88ac6c6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T03:36:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dbdf106
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T03:36:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 88ac6c6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Fixing omissions and formating.

sagemaker-bot · 2022-02-23T05:58:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c894434
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T05:58:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a82cb7a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T06:05:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c894434
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T06:05:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a82cb7a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-02-23T06:13:23Z

Codecov Report

Merging #2951 (13223ba) into master (a387c4c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2951   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         196      196           
  Lines       16610    16610           
=======================================
  Hits        14933    14933           
  Misses       1677     1677

Impacted Files	Coverage Δ
src/sagemaker/estimator.py	`91.32% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a387c4c...13223ba. Read the comment docs.

sagemaker-bot · 2022-02-23T06:31:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c894434
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-23T06:31:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a82cb7a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Note: This might need a larger review, as the arbitrary use of json.dumps introduces a lot of ambiguity with respect to the underlying types.

sagemaker-bot · 2022-02-24T06:38:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3095949
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-24T07:43:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3095949
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-24T07:50:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3095949
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…nfig.

sagemaker-bot · 2022-03-01T21:12:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7cd161a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-01T22:17:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7cd161a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-01T23:07:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7cd161a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Hyperparameters are only json encoded at the end of setting up a Sagemaker job.

sagemaker-bot · 2022-03-02T00:17:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e7d7085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-02T00:54:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e7d7085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-02T00:55:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e7d7085
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan

black-check is failing. Can you reformat?

ahsan-z-khan · 2022-03-03T19:23:38Z

tests/unit/test_estimator.py

@@ -1268,7 +1267,7 @@ def test_custom_code_bucket_without_prefix(time, sagemaker_session):
    _, _, train_kwargs = sagemaker_session.train.mock_calls[0]
    assert train_kwargs["hyperparameters"]["sagemaker_submit_directory"] == json.dumps(
        expected_submit_dir
-    )
+    ) 


lets remove this blank space

sagemaker-bot · 2022-03-05T02:04:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c87d17c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-05T02:26:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c87d17c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-05T02:38:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c87d17c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-05T03:16:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c87d17c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2022-03-16T00:07:35Z

Thanks for contributing,
Unit tests have been failing for this PR, can you fix them @osdf

I would suggest fixing this by a change in here to accept strings, rather than changing Estimator.

sagemaker-bot · 2022-03-18T00:02:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 13223ba
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T00:10:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 13223ba
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T00:33:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 13223ba
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni · 2022-12-02T21:07:18Z

Closing as this change has been addressed by #3043

MadhubalasriB and others added 8 commits February 22, 2022 02:25

feature: adding customer metadata support to registermodel step (aws#…

1cbfe50

…2935)

feat: jumpstart model id suggestions (aws#2899)

663983d

Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: HappyAmazonian <[email protected]>

feat: override jumpstart content bucket (aws#2901)

d529475

Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: HappyAmazonian <[email protected]>

fix: Support primitive types for left value of ConditionSteps (aws#2886)

a98a6d8

Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Navin Soni <[email protected]>

fix: Add lineage doc (aws#2937)

a928c0a

fix: update lineage_trial_compoment get pipeline execution arn (aws#2944

668359f

) Co-authored-by: Shreya Pandit <[email protected]>

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

0e4fd55

Co-authored-by: Dewen Qi <[email protected]>

Fix for aws#2949.

88ac6c6

Extend the set of types that are not handled by json.dumps to elementary types.

BasilBeirouti force-pushed the dev branch from 0e4fd55 to 26b984a Compare February 23, 2022 02:20

Update test_estimator.py

dbdf106

Fixing tests to reflect desired behaviour.

Christian Osendorfer and others added 2 commits February 22, 2022 21:35

Updating PR.

a82cb7a

Fixing omissions and formating.

Merge branch 'dev' into fix#2949

c894434

Removing spurious json.loads.

3095949

Note: This might need a larger review, as the arbitrary use of json.dumps introduces a lot of ambiguity with respect to the underlying types.

Hyperparameters are json encoded at the end of setting up training co…

7cd161a

…nfig.

Fix for aws#2949.

e7d7085

Hyperparameters are only json encoded at the end of setting up a Sagemaker job.

ahsan-z-khan suggested changes Mar 3, 2022

View reviewed changes

Resolve black formating issue.

c87d17c

mufaddal-rohawala changed the base branch from dev to master March 15, 2022 23:54

Merge branch 'master' into fix#2949

13223ba

mufaddal-rohawala added the needs contributor changes label Mar 18, 2022

mufaddal-rohawala closed this May 13, 2022

mufaddal-rohawala reopened this May 13, 2022

vikas0203 requested review from a team, navinsoni and knikure and removed request for a team November 23, 2022 21:34

vikas0203 assigned knikure Nov 23, 2022

navinsoni closed this Dec 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for #2949. #2951

Fix for #2949. #2951

osdf commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

codecov-commenter commented Feb 23, 2022 •

edited

Loading

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 23, 2022

sagemaker-bot commented Feb 24, 2022

sagemaker-bot commented Feb 24, 2022

sagemaker-bot commented Feb 24, 2022

sagemaker-bot commented Mar 1, 2022

sagemaker-bot commented Mar 1, 2022

sagemaker-bot commented Mar 1, 2022

sagemaker-bot commented Mar 2, 2022

sagemaker-bot commented Mar 2, 2022

sagemaker-bot commented Mar 2, 2022

ahsan-z-khan left a comment

ahsan-z-khan Mar 3, 2022

sagemaker-bot commented Mar 5, 2022

sagemaker-bot commented Mar 5, 2022

sagemaker-bot commented Mar 5, 2022

sagemaker-bot commented Mar 5, 2022

mufaddal-rohawala commented Mar 16, 2022

sagemaker-bot commented Mar 18, 2022

sagemaker-bot commented Mar 18, 2022

sagemaker-bot commented Mar 18, 2022

navinsoni commented Dec 2, 2022

Fix for #2949. #2951

Fix for #2949. #2951

Conversation

osdf commented Feb 23, 2022

Merge Checklist

General

Tests

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

codecov-commenter commented Feb 23, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 24, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 1, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 2, 2022

AWS CodeBuild CI Report

ahsan-z-khan left a comment

Choose a reason for hiding this comment

ahsan-z-khan Mar 3, 2022

Choose a reason for hiding this comment

sagemaker-bot commented Mar 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2022

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 16, 2022

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Mar 18, 2022

AWS CodeBuild CI Report

navinsoni commented Dec 2, 2022

codecov-commenter commented Feb 23, 2022 •

edited

Loading