feature: adding customer metadata support to registermodel step #2935

MadhubalasriB · 2022-02-15T03:52:57Z

Issue #, if available:

Description of changes: Adding customer metadata support for Register model step

Testing done:
Verified unit and integ tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-02-15T04:03:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 747c239
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T04:05:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 747c239
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T04:24:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 747c239
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T07:27:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 538dbdf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T07:56:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 46dd800
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T07:57:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d216a86
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T08:01:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6a5f707
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T08:32:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 538dbdf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T08:34:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 538dbdf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T08:49:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 46dd800
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T08:49:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d216a86
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T08:49:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6a5f707
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T09:03:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6a5f707
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T09:15:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fbe676d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T09:18:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d216a86
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T09:35:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a1182f1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-02-15T09:53:38Z

Codecov Report

Merging #2935 (3516f51) into dev (46391bf) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev    #2935      +/-   ##
==========================================
- Coverage   89.50%   89.47%   -0.03%     
==========================================
  Files         196      196              
  Lines       16574    16584      +10     
==========================================
+ Hits        14834    14839       +5     
- Misses       1740     1745       +5

Impacted Files	Coverage Δ
src/sagemaker/estimator.py	`91.32% <ø> (ø)`
src/sagemaker/model.py	`91.48% <ø> (ø)`
src/sagemaker/mxnet/model.py	`96.36% <ø> (ø)`
src/sagemaker/pytorch/model.py	`85.45% <ø> (ø)`
src/sagemaker/tensorflow/model.py	`90.21% <ø> (ø)`
src/sagemaker/workflow/step_collections.py	`92.55% <ø> (ø)`
src/sagemaker/session.py	`70.39% <44.44%> (-0.19%)`	⬇️
src/sagemaker/workflow/_utils.py	`85.48% <100.00%> (+0.11%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46391bf...3516f51. Read the comment docs.

sagemaker-bot · 2022-02-15T10:00:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: fbe676d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T10:02:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 46dd800
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T10:02:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d216a86
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T10:03:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6a5f707
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T10:17:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a1182f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T10:29:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cda6b3c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T10:32:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: fbe676d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T10:32:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a1182f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T11:11:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cda6b3c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-15T11:52:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cda6b3c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

staubhp · 2022-02-16T16:25:12Z

src/sagemaker/session.py

+                self.sagemaker_client.describe_model_package_group(
+                    ModelPackageGroupName=request["ModelPackageGroupName"]
+                )
+            except ClientError:


Any way this exception can be made more specific? IE check the error code, or test for sagemaker_client.exceptions.ResourceNotFound if that API returns ResourceNotFound

It would be a validation exception which comes under client error. This is the only type of clienterror we see for describe_model_package_group.

sagemaker-bot · 2022-02-18T00:21:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3516f51
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-18T01:14:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3516f51
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-18T02:42:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3516f51
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…2935)

feature: adding customer metadata support to registermodel step

747c239

Modifying session object

538dbdf

MadhubalasriB added 3 commits February 15, 2022 13:19

Fixing lint errors

46dd800

fixing lint

d216a86

fixing lint errors

6a5f707

Fixing black-check formats

fbe676d

Removing redundant test

a1182f1

Fixing black-check errors

cda6b3c

staubhp reviewed Feb 16, 2022

View reviewed changes

staubhp self-requested a review February 16, 2022 18:49

staubhp approved these changes Feb 16, 2022

View reviewed changes

Merge branch 'dev' into customerMetadata

3516f51

navinsoni approved these changes Feb 18, 2022

View reviewed changes

shreyapandit approved these changes Feb 18, 2022

View reviewed changes

navinsoni merged commit 21ac6fd into aws:dev Feb 18, 2022

navinsoni pushed a commit that referenced this pull request Feb 22, 2022

feature: adding customer metadata support to registermodel step (#2935)

1cbfe50

navinsoni pushed a commit that referenced this pull request Feb 22, 2022

feature: adding customer metadata support to registermodel step (#2935)

89ef9ee

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Mar 31, 2022

feature: adding customer metadata support to registermodel step (aws#…

bf34084

…2935)

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Mar 31, 2022

feature: adding customer metadata support to registermodel step (aws#…

937a8be

…2935)

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 8, 2022

feature: adding customer metadata support to registermodel step (aws#…

deeaaf4

…2935)

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 13, 2022

feature: adding customer metadata support to registermodel step (aws#…

0d6b85a

…2935)

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 19, 2022

feature: adding customer metadata support to registermodel step (aws#…

8dcc55a

…2935)

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 19, 2022

feature: adding customer metadata support to registermodel step (aws#…

0c55c61

…2935)

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 25, 2022

feature: adding customer metadata support to registermodel step (aws#…

bd03840

…2935)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: adding customer metadata support to registermodel step #2935

feature: adding customer metadata support to registermodel step #2935

MadhubalasriB commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

codecov-commenter commented Feb 15, 2022 •

edited

Loading

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

sagemaker-bot commented Feb 15, 2022

staubhp Feb 16, 2022

MadhubalasriB Feb 16, 2022

sagemaker-bot commented Feb 18, 2022

sagemaker-bot commented Feb 18, 2022

sagemaker-bot commented Feb 18, 2022

feature: adding customer metadata support to registermodel step #2935

feature: adding customer metadata support to registermodel step #2935

Conversation

MadhubalasriB commented Feb 15, 2022

Merge Checklist

General

Tests

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

codecov-commenter commented Feb 15, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 15, 2022

AWS CodeBuild CI Report

staubhp Feb 16, 2022

Choose a reason for hiding this comment

MadhubalasriB Feb 16, 2022

Choose a reason for hiding this comment

sagemaker-bot commented Feb 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 18, 2022

AWS CodeBuild CI Report

codecov-commenter commented Feb 15, 2022 •

edited

Loading