We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
https://github.com/aws/sagemaker-training-toolkit/blob/master/src/sagemaker_training/logging_config.py#L29 needs an integer for level. Through https://github.com/aws/sagemaker-python-sdk/blob/dev/src/sagemaker/estimator.py#L685 the value in hyperparams[CONTAINER_LOG_LEVEL_PARAM_NAME] (which is logging.INFO, the integer value 20) gets converted to a string ('20'), and hence https://github.com/aws/sagemaker-training-toolkit/blob/master/src/sagemaker_training/logging_config.py#L37 breaks.
level
hyperparams[CONTAINER_LOG_LEVEL_PARAM_NAME]
logging.INFO
20
'20'
Similarly (if one fixes the '20' issue by hand), https://github.com/aws/sagemaker-training-toolkit/blob/master/src/sagemaker_training/files.py#L136 won't identify that code needs to be downloaded from s3, because the entry for https://github.com/aws/sagemaker-python-sdk/blob/dev/src/sagemaker/model.py#L65 is wrapped into a string, having the form "'s3://....'".
"'s3://....'"
To reproduce Run with script-mode, using newest sagemaker python sdk (2.76.0)
Expected behavior It works.
System information A description of your system. Please provide:
Additional context Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Fix for aws#2949.
88ac6c6
Extend the set of types that are not handled by json.dumps to elementary types.
e7d7085
Hyperparameters are only json encoded at the end of setting up a Sagemaker job.
Fixed by #3043
Sorry, something went wrong.
No branches or pull requests
Describe the bug
https://github.com/aws/sagemaker-training-toolkit/blob/master/src/sagemaker_training/logging_config.py#L29 needs an integer for
level
.Through https://github.com/aws/sagemaker-python-sdk/blob/dev/src/sagemaker/estimator.py#L685 the value in
hyperparams[CONTAINER_LOG_LEVEL_PARAM_NAME]
(which islogging.INFO
, the integer value20
) gets converted to a string ('20'
), and hence https://github.com/aws/sagemaker-training-toolkit/blob/master/src/sagemaker_training/logging_config.py#L37 breaks.Similarly (if one fixes the
'20'
issue by hand),https://github.com/aws/sagemaker-training-toolkit/blob/master/src/sagemaker_training/files.py#L136 won't identify that code needs to be downloaded from s3, because the entry for https://github.com/aws/sagemaker-python-sdk/blob/dev/src/sagemaker/model.py#L65 is wrapped into a string, having the form
"'s3://....'"
.To reproduce
Run with script-mode, using newest sagemaker python sdk (2.76.0)
Expected behavior
It works.
System information
A description of your system. Please provide:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: