fix: Improve Pipeline workflow unit test branch coverage #2878

qidewenwhen · 2022-01-28T01:14:37Z

Description of changes:

Fix tiny bugs among multiple classes
Add more unit tests to improve branch coverage
Exclude script files and deprecated classes from the coverage calculation

Testing done: Unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-01-28T01:39:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b46eda3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-01-28T02:02:48Z

Codecov Report

Merging #2878 (df5e930) into dev (f744827) will increase coverage by 0.33%.
The diff coverage is 100.00%.

❗ Current head df5e930 differs from pull request most recent head f47428a. Consider uploading reports for the commit f47428a to get more accurate results

@@            Coverage Diff             @@
##              dev    #2878      +/-   ##
==========================================
+ Coverage   89.48%   89.81%   +0.33%     
==========================================
  Files         196      196              
  Lines       16592    16545      -47     
==========================================
+ Hits        14847    14860      +13     
+ Misses       1745     1685      -60

Impacted Files	Coverage Δ
src/sagemaker/workflow/_repack_model.py	`100.00% <ø> (+78.26%)`	⬆️
src/sagemaker/workflow/_utils.py	`87.90% <ø> (+2.41%)`	⬆️
src/sagemaker/workflow/condition_step.py	`100.00% <ø> (+10.81%)`	⬆️
src/sagemaker/workflow/functions.py	`100.00% <100.00%> (+4.16%)`	⬆️
src/sagemaker/workflow/lambda_step.py	`100.00% <100.00%> (+9.09%)`	⬆️
src/sagemaker/workflow/step_collections.py	`98.93% <100.00%> (+6.38%)`	⬆️
src/sagemaker/workflow/steps.py	`97.79% <0.00%> (+0.44%)`	⬆️
src/sagemaker/workflow/properties.py	`89.47% <0.00%> (+1.31%)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c9fb3...f47428a. Read the comment docs.

sagemaker-bot · 2022-01-28T02:03:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 78d9f23
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T02:29:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b46eda3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T02:43:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 78d9f23
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T02:47:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b46eda3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T03:22:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 78d9f23
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T18:57:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d0cd364
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T19:52:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d0cd364
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T19:52:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d0cd364
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/workflow/_repack_model.py

src/sagemaker/workflow/condition_step.py

tests/unit/sagemaker/workflow/test_functions.py

sagemaker-bot · 2022-02-02T23:35:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 267d2a3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T00:39:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 267d2a3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T01:12:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c073502
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T01:55:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c073502
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T01:55:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 267d2a3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T02:22:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c073502
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T20:41:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 973e012
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T21:09:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 973e012
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T21:14:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 973e012
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-21T18:38:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: df5e930
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-21T19:29:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: df5e930
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-21T19:48:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: df5e930
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-21T22:28:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f47428a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-21T23:18:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f47428a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-21T23:47:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f47428a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/workflow/step_collections.py

sagemaker-bot · 2022-02-22T03:17:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 833847a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-22T04:06:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 833847a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-22T05:04:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 833847a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Dewen Qi <[email protected]>

qidewenwhen force-pushed the dev branch from b46eda3 to 78d9f23 Compare January 28, 2022 01:45

jerrypeng7773 reviewed Jan 28, 2022

View reviewed changes

src/sagemaker/workflow/_repack_model.py Show resolved Hide resolved

jerrypeng7773 reviewed Jan 28, 2022

View reviewed changes

src/sagemaker/workflow/condition_step.py Show resolved Hide resolved

jeniyat force-pushed the dev branch 2 times, most recently from f5e6849 to 34b07c0 Compare January 29, 2022 23:28

staubhp reviewed Jan 31, 2022

View reviewed changes

tests/unit/sagemaker/workflow/test_functions.py Outdated Show resolved Hide resolved

qidewenwhen force-pushed the dev branch from d0cd364 to 267d2a3 Compare February 2, 2022 23:26

jerrypeng7773 approved these changes Feb 3, 2022

View reviewed changes

staubhp approved these changes Feb 3, 2022

View reviewed changes

mufaddal-rohawala force-pushed the dev branch 3 times, most recently from 96c01d7 to c437191 Compare February 5, 2022 00:08

jeniyat force-pushed the dev branch from 9d612a7 to bb7563f Compare February 7, 2022 23:40

qidewenwhen force-pushed the dev branch from c073502 to 79a64a6 Compare February 9, 2022 22:07

qidewenwhen force-pushed the dev branch from 84b57dd to 973e012 Compare February 16, 2022 20:20

qidewenwhen force-pushed the dev branch from 973e012 to df5e930 Compare February 21, 2022 18:13

qidewenwhen force-pushed the dev branch from df5e930 to f47428a Compare February 21, 2022 22:03

navinsoni force-pushed the dev branch from 3e68e14 to 668359f Compare February 22, 2022 02:34

BasilBeirouti approved these changes Feb 22, 2022

View reviewed changes

src/sagemaker/workflow/step_collections.py Show resolved Hide resolved

fix: improve Pipeline workflow unit test branch coverage

833847a

navinsoni force-pushed the dev branch from f47428a to 833847a Compare February 22, 2022 02:52

navinsoni approved these changes Feb 22, 2022

View reviewed changes

navinsoni merged commit 0e4fd55 into aws:dev Feb 22, 2022

navinsoni pushed a commit that referenced this pull request Feb 22, 2022

fix: Improve Pipeline workflow unit test branch coverage (#2878)

cb830cc

Co-authored-by: Dewen Qi <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Mar 31, 2022

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

a3eea2b

Co-authored-by: Dewen Qi <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Mar 31, 2022

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

34a0689

Co-authored-by: Dewen Qi <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 8, 2022

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

a8de7fb

Co-authored-by: Dewen Qi <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 13, 2022

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

e4ff3dc

Co-authored-by: Dewen Qi <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 19, 2022

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

f912407

Co-authored-by: Dewen Qi <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 19, 2022

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

04328ef

Co-authored-by: Dewen Qi <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 19, 2022

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

ac13b27

Co-authored-by: Dewen Qi <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 25, 2022

fix: Improve Pipeline workflow unit test branch coverage (aws#2878)

125cdcf

Co-authored-by: Dewen Qi <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Improve Pipeline workflow unit test branch coverage #2878

fix: Improve Pipeline workflow unit test branch coverage #2878

qidewenwhen commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

codecov-commenter commented Jan 28, 2022 •

edited

Loading

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Feb 2, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 21, 2022

sagemaker-bot commented Feb 21, 2022

sagemaker-bot commented Feb 21, 2022

sagemaker-bot commented Feb 21, 2022

sagemaker-bot commented Feb 21, 2022

sagemaker-bot commented Feb 21, 2022

sagemaker-bot commented Feb 22, 2022

sagemaker-bot commented Feb 22, 2022

sagemaker-bot commented Feb 22, 2022

fix: Improve Pipeline workflow unit test branch coverage #2878

fix: Improve Pipeline workflow unit test branch coverage #2878

Conversation

qidewenwhen commented Jan 28, 2022

Merge Checklist

General

Tests

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

codecov-commenter commented Jan 28, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 2, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 22, 2022

AWS CodeBuild CI Report

codecov-commenter commented Jan 28, 2022 •

edited

Loading