Skip to content

Commit e4ff3dc

Browse files
qidewenwhenDewen Qi
authored andcommitted
fix: Improve Pipeline workflow unit test branch coverage (aws#2878)
Co-authored-by: Dewen Qi <[email protected]>
1 parent 45b8b64 commit e4ff3dc

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

tests/integ/test_workflow.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
ConditionLessThanOrEqualTo,
6868
)
6969
from sagemaker.workflow.condition_step import ConditionStep
70-
from sagemaker.workflow.condition_step import JsonGet as ConditionStepJsonGet
7170
from sagemaker.workflow.callback_step import (
7271
CallbackStep,
7372
CallbackOutput,
@@ -2835,8 +2834,8 @@ def test_end_to_end_pipeline_successful_execution(
28352834

28362835
# define condition step
28372836
cond_lte = ConditionLessThanOrEqualTo(
2838-
left=ConditionStepJsonGet(
2839-
step=step_eval,
2837+
left=JsonGet(
2838+
step_name=step_eval.name,
28402839
property_file=evaluation_report,
28412840
json_path="regression_metrics.mse.value",
28422841
),

tests/unit/sagemaker/workflow/test_functions.py

+2
Original file line numberDiff line numberDiff line change
@@ -233,3 +233,5 @@ def test_add_func_of_json_get():
233233
json_get_func1 + json_get_func2
234234

235235
assert str(error.value) == "Pipeline variables do not support concatenation."
236+
=======
237+
>>>>>>> 0e4fd556 (fix: Improve Pipeline workflow unit test branch coverage (#2878))

0 commit comments

Comments
 (0)