feat: override jumpstart content bucket #2901

evakravi · 2022-02-04T21:29:39Z

Issue #, if available:

Description of changes:
feat: override jumpstart content bucket. This feature allows developers to test jumpstart specs/manifest files that are not in production, but rather hosted in an arbitrary s3 bucket.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2022-02-04T21:43:33Z

Codecov Report

Merging #2901 (91ff059) into dev (21ac6fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2901   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files         196      196           
  Lines       16584    16584           
=======================================
  Hits        14839    14839           
  Misses       1745     1745

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ac6fd...91ff059. Read the comment docs.

sagemaker-bot · 2022-02-04T21:49:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 115037a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-04T22:30:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 115037a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-04T22:33:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 115037a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

JGuinegagne

approving: just one question

JGuinegagne · 2022-02-07T21:19:59Z

src/sagemaker/jumpstart/utils.py

+        constants.ENV_VARIABLE_JUMPSTART_CONTENT_BUCKET_OVERRIDE in os.environ
+        and len(os.environ[constants.ENV_VARIABLE_JUMPSTART_CONTENT_BUCKET_OVERRIDE]) > 0
+    ):
+        return os.environ[constants.ENV_VARIABLE_JUMPSTART_CONTENT_BUCKET_OVERRIDE]


question: do you think we should log a warning if there is an override?

It's not really a warning -- i.e. we shouldn't attach negative connotation to this. Maybe an INFO?

sounds good, i agree an INFO log is more appropriate

sagemaker-bot · 2022-02-07T21:45:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 327f8f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T22:30:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 327f8f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T22:38:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 327f8f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T19:10:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 468fc08
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T19:52:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 468fc08
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T20:39:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 468fc08
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-09T13:54:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7aa181d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-09T14:38:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7aa181d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-09T14:49:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7aa181d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-10T21:34:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b095a46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-10T22:27:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b095a46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-10T22:48:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b095a46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T14:01:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 28e182e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T14:34:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 28e182e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T14:45:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 28e182e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T17:33:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 28e182e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T21:03:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c1a23c6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T21:40:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c1a23c6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-17T00:39:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c1a23c6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shreyapandit · 2022-02-17T23:53:25Z

src/sagemaker/jumpstart/utils.py

@@ -60,6 +61,14 @@ def get_jumpstart_content_bucket(region: str) -> str:
    Raises:
        RuntimeError: If JumpStart is not launched in ``region``.


Where is this used downstream and what will happen for multiple values?

This is used for getting the bucket for all JumpStart resources.

sagemaker-bot · 2022-02-18T08:15:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c1a23c6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-18T15:10:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 91ff059
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-18T15:53:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 91ff059
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-18T17:13:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 91ff059
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-18T23:16:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 91ff059
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: qidewenwhen <[email protected]> Co-authored-by: HappyAmazonian <[email protected]>

mufaddal-rohawala force-pushed the dev branch 2 times, most recently from 96c01d7 to c437191 Compare February 5, 2022 00:08

JGuinegagne approved these changes Feb 7, 2022

View reviewed changes

evakravi force-pushed the feat/override-jumpstart-content-bucket branch from 115037a to 327f8f1 Compare February 7, 2022 21:28

jeniyat force-pushed the dev branch from 9d612a7 to bb7563f Compare February 7, 2022 23:40

evakravi force-pushed the feat/override-jumpstart-content-bucket branch from 327f8f1 to 468fc08 Compare February 8, 2022 18:47

jeniyat force-pushed the dev branch from 7ea4b80 to bb7563f Compare February 9, 2022 00:11

JGuinegagne approved these changes Feb 9, 2022

View reviewed changes

evakravi added 2 commits February 9, 2022 13:33

feat: override jumpstart content bucket

6ec51c2

chore: log info msg when overriding jumpstart bucket

7aa181d

evakravi force-pushed the feat/override-jumpstart-content-bucket branch from 468fc08 to 7aa181d Compare February 9, 2022 13:33

fix: jumpstart docs

b095a46

navinsoni added 2 commits February 15, 2022 00:30

fix: Update Static Endpoint (aws#2931)

b591959

Add exception in test_action (aws#2938)

3c5ea3a

HappyAmazonian and others added 2 commits February 16, 2022 03:48

change: use recommended inference image uri from Neo API (aws#2923)

a765512

Merge branch 'dev' into feat/override-jumpstart-content-bucket

28e182e

navinsoni force-pushed the dev branch from 58cf626 to 46391bf Compare February 16, 2022 19:55

Merge branch 'dev' into feat/override-jumpstart-content-bucket

c1a23c6

shreyapandit approved these changes Feb 17, 2022

View reviewed changes

shreyapandit reviewed Feb 17, 2022

View reviewed changes

navinsoni approved these changes Feb 18, 2022

View reviewed changes

Merge branch 'dev' into feat/override-jumpstart-content-bucket

91ff059

navinsoni merged commit 8215dd2 into aws:dev Feb 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: override jumpstart content bucket #2901

feat: override jumpstart content bucket #2901

evakravi commented Feb 4, 2022 •

edited

Loading

codecov-commenter commented Feb 4, 2022 •

edited

Loading

sagemaker-bot commented Feb 4, 2022

sagemaker-bot commented Feb 4, 2022

sagemaker-bot commented Feb 4, 2022

JGuinegagne left a comment

JGuinegagne Feb 7, 2022

evakravi Feb 7, 2022

JGuinegagne Feb 7, 2022

sagemaker-bot commented Feb 7, 2022

sagemaker-bot commented Feb 7, 2022

sagemaker-bot commented Feb 7, 2022

sagemaker-bot commented Feb 8, 2022

sagemaker-bot commented Feb 8, 2022

sagemaker-bot commented Feb 8, 2022

sagemaker-bot commented Feb 9, 2022

sagemaker-bot commented Feb 9, 2022

sagemaker-bot commented Feb 9, 2022

sagemaker-bot commented Feb 10, 2022

sagemaker-bot commented Feb 10, 2022

sagemaker-bot commented Feb 10, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 17, 2022

shreyapandit Feb 17, 2022

evakravi Feb 18, 2022

sagemaker-bot commented Feb 18, 2022

sagemaker-bot commented Feb 18, 2022

sagemaker-bot commented Feb 18, 2022

sagemaker-bot commented Feb 18, 2022

sagemaker-bot commented Feb 18, 2022

		@@ -60,6 +61,14 @@ def get_jumpstart_content_bucket(region: str) -> str:
		Raises:
		RuntimeError: If JumpStart is not launched in ``region``.

feat: override jumpstart content bucket #2901

feat: override jumpstart content bucket #2901

Conversation

evakravi commented Feb 4, 2022 • edited Loading

Merge Checklist

General

Tests

codecov-commenter commented Feb 4, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Feb 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 4, 2022

AWS CodeBuild CI Report

JGuinegagne left a comment

Choose a reason for hiding this comment

JGuinegagne Feb 7, 2022

Choose a reason for hiding this comment

evakravi Feb 7, 2022

Choose a reason for hiding this comment

JGuinegagne Feb 7, 2022

Choose a reason for hiding this comment

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 10, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 10, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 10, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 17, 2022

AWS CodeBuild CI Report

shreyapandit Feb 17, 2022

Choose a reason for hiding this comment

evakravi Feb 18, 2022

Choose a reason for hiding this comment

sagemaker-bot commented Feb 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 18, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 18, 2022

AWS CodeBuild CI Report

evakravi commented Feb 4, 2022 •

edited

Loading

codecov-commenter commented Feb 4, 2022 •

edited

Loading