breaking: merge v2 changes into master #1802

laurenyu · 2020-08-04T15:05:48Z

Issue #, if available:
#1459

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…de for v2 (#1492) As a start, this class ensures that the framework_version parameter is specified when framework classes are instantiated.

…es (#1531) This change also removes the associated serialization/deserialization code used by TensorFlowPredictor and the locally copied TFS APIs.

…gration script (#1534)

…iers (#1536)

…y parameter (#1537)

This change also reorganizes the TF unit tests a bit, and updates the tf_version fixture to include recent versions.

…w.model (#1541) This changes the following two classes: * sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel * sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor This commit also changes two attributes to match the other framework model classes: * FRAMEWORK_NAME --> __framework_name__ * _framework_version --> framework_version

…el_dir=False if needed (#1540)

… tool (#1550)

…migration tool (#1551)

…pgrade (#1547)

* breaking: require framework_version, py_version for mxnet * framework_version, py_version required for framework MXNet * framework_version, py_version required for framework MXNetModel * image_name required if either framework_version or py_version None * re-order of non-default args, convention to follow entry_point * unit and integ testing updates * doc updates * ignore coverage results for py27 env due to v2 migration scripts

* small updates to docstrings * small updates to tests Co-authored-by: Chuyang <[email protected]>

…1579)

sagemaker-bot · 2020-08-04T15:13:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 99773e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-08-04T15:31:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 99773e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-08-04T15:45:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 99773e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-08-04T15:49:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 99773e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable

ship it

       !
       !
       ^
      / \
     /___\
    |=   =|
    |  s  |
    |  a  |
    |  g  |
    |  e  |
    |  m  |
    |  a  |
    |  k  |
    |  e  |
    |  r  |
    |     |
   /|##!##|\
  / |##!##| \
 /  |##!##|  \
|  / ^ | ^ \  |
| /  ( | )  \ |
|/   ( | )   \|
    ((   ))
   ((  :  ))
   ((  :  ))
    ((   ))
     (( ))
      ( )
       .
       .
       .

knakad

!!!

sagemaker-bot · 2020-08-04T17:30:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4a744a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable

ship it!

       ___   
      |__ \  
 __   __ ) | 
 \ \ / // /  
  \ V // /_  
   \_/|____|

sagemaker-bot · 2020-08-04T17:48:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4a744a1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-08-04T18:02:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4a744a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-08-04T18:03:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4a744a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu and others added 30 commits May 14, 2020 13:10

change: create ASTTransformer class to handle migrating Python SDK co…

f7f0ac6

…de for v2 (#1492) As a start, this class ensures that the framework_version parameter is specified when framework classes are instantiated.

change: add class to read Python scripts and update code for v2 (#1497)

81ad62b

infra: add tools/ dir to pylint check (#1499)

d197b74

change: add CLI wrapper for v2 migration script (#1500)

88518e0

change: add .ipynb file support for v2 migration script (#1508)

57b2a22

breaking: remove estimator parameters for TF legacy mode (#1510)

40f1d75

change: add v2 migration script to console_scripts in setup.py (#1530)

5b078f7

breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…

c65c80f

…es (#1531) This change also removes the associated serialization/deserialization code used by TensorFlowPredictor and the locally copied TFS APIs.

change: convert TF legacy mode parameters to hyperparameters in v2 mi…

a680be1

…gration script (#1534)

infra: add unit tests for v2 migration script file updaters and modif…

614fe7e

…iers (#1536)

change: remove scipy from dependencies (#1518)

6eeca73

change: make v2 migration script remove legacy run_tensorboard_locall…

0c5392f

…y parameter (#1537)

breaking: force image_uri to be passed for legacy TF images (#1539)

d0eb4a2

This change also reorganizes the TF unit tests a bit, and updates the tf_version fixture to include recent versions.

change: make v2 migration script remove script_mode param and set mod…

242f81b

…el_dir=False if needed (#1540)

Merge branch 'master' into zwei

0f5c9b5

infra: remove TF from optional dependencies (#1548)

3014421

fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…

2099a8d

… tool (#1550)

fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …

baf1c35

…migration tool (#1551)

change: update v2 migration tool to rename TFS classes/imports (#1552)

de54a76

doc: update TF documentation to reflect breaking changes and how to u…

97cd594

…pgrade (#1547)

doc: change "v2" to "version 2.0 or later" (#1557)

800f960

doc: start v2 usage and migration documentation (#1553)

18e402c

doc: remove documentation about old MXNet training script format (#1560)

7a7c658

change: require framework_version, py_version for xgboost (#1570)

5233dfc

* small updates to docstrings * small updates to tests Co-authored-by: Chuyang <[email protected]>

breaking: require framework_version, py_version for sklearn (#1576)

9977206

breaking: require framework_version, py_version for pytorch (#1568)

7919331

breaking: change Model parameter order to make model_data optional (#…

9df3f5a

…1579)

breaking: require framework_version, py_version for tensorflow (#1580)

dbdaf50

change: Support multiple Accept types (#1794)

99773e5

laurenyu mentioned this pull request Aug 4, 2020

breaking: remove unused bin/sagemaker-submit file #1803

Merged

7 tasks

metrizable requested review from ajaykarpur and chuyang-deng August 4, 2020 16:31

metrizable previously approved these changes Aug 4, 2020

View reviewed changes

knakad previously approved these changes Aug 4, 2020

View reviewed changes

ajaykarpur previously approved these changes Aug 4, 2020

View reviewed changes

chuyang-deng previously approved these changes Aug 4, 2020

View reviewed changes

breaking: remove unused bin/sagemaker-submit file (#1803)

4a744a1

laurenyu dismissed stale reviews from chuyang-deng, ajaykarpur, knakad, and metrizable via 4a744a1 August 4, 2020 17:22

bveeramani approved these changes Aug 4, 2020

View reviewed changes

ajaykarpur approved these changes Aug 4, 2020

View reviewed changes

ajaykarpur requested review from chuyang-deng and metrizable August 4, 2020 17:34

chuyang-deng approved these changes Aug 4, 2020

View reviewed changes

metrizable approved these changes Aug 4, 2020

View reviewed changes

knakad approved these changes Aug 4, 2020

View reviewed changes

laurenyu merged commit 64f600d into master Aug 4, 2020

knikure deleted the zwei branch November 3, 2023 00:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

breaking: merge v2 changes into master #1802

breaking: merge v2 changes into master #1802

laurenyu commented Aug 4, 2020 •

edited

Loading

sagemaker-bot commented Aug 4, 2020

sagemaker-bot commented Aug 4, 2020

sagemaker-bot commented Aug 4, 2020

sagemaker-bot commented Aug 4, 2020

metrizable left a comment

knakad left a comment

sagemaker-bot commented Aug 4, 2020

metrizable left a comment

sagemaker-bot commented Aug 4, 2020

sagemaker-bot commented Aug 4, 2020

sagemaker-bot commented Aug 4, 2020

breaking: merge v2 changes into master #1802

breaking: merge v2 changes into master #1802

Conversation

laurenyu commented Aug 4, 2020 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Aug 4, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2020

AWS CodeBuild CI Report

metrizable left a comment

Choose a reason for hiding this comment

knakad left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Aug 4, 2020

AWS CodeBuild CI Report

metrizable left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Aug 4, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2020

AWS CodeBuild CI Report

laurenyu commented Aug 4, 2020 •

edited

Loading