Skip to content

change: add class to read Python scripts and update code for v2 #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2020

Conversation

laurenyu
Copy link
Contributor

Issue #, if available:
#1478

Description of changes:
follow-up to #1492. This class reads in Python source files and feeds the code to ASTTransformer.

unit tests will come later (see #1478)

Testing done:
manual testing:

# sample input script
$ cat input.py
from sagemaker.mxnet import MXNet

m = MXNet()  # TODO: fill in parameters
m.fit()

# run with an output_path that creates directories
$ python -c "import files; files.PyFileUpdater('input.py', 'foo/bar/output.py').update()" && cat foo/bar/output.py
from sagemaker.mxnet import MXNet

m = MXNet(framework_version='1.2.0')  # TODO: fill in parameters
m.fit()

# run with an output_path that doesn't contain directories
$ python -c "import files; files.PyFileUpdater('input.py', 'output.py').update()" && cat output.py
from sagemaker.mxnet import MXNet

m = MXNet(framework_version='1.2.0')  # TODO: fill in parameters
m.fit()

# run again to check for warning message from the output file already existing
$ python -c "import files; files.PyFileUpdater('input.py', 'output.py').update()" && cat output.py
Overwriting file output.py
from sagemaker.mxnet import MXNet

m = MXNet(framework_version='1.2.0')  # TODO: fill in parameters
m.fit()

# run using the same path for both input_file and output_file
$ python -c "import files; files.PyFileUpdater('input.py', 'input.py').update()" && cat input.py
Overwriting file input.py
from sagemaker.mxnet import MXNet

m = MXNet(framework_version='1.2.0')  # TODO: fill in parameters
m.fit()
(venv) ~/Documents/workspace/sagemaker-python-sdk/tools/compatibility/v2$

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to any/all clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants