Skip to content

change: require framework_version, py_version for xgboost #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

metrizable
Copy link
Contributor

During work of requiring framework_version for all frameworks, some small doc and test improvements.

Issue #, if available: #1465

Description of changes:

changes include:

  • small updates to docstrings
  • small updates to tests

Testing done:

 % tox --parallel 3 tests/unit
✔ OK black-format in 12.047 seconds
✔ OK flake8 in 25.667 seconds
✔ OK twine in 15.207 seconds
✔ OK pylint in 39.186 seconds
✔ OK doc8 in 22.472 seconds
✔ OK py36 in 35.675 seconds
✔ OK py37 in 37.08 seconds
✔ OK sphinx in 1 minute, 43.377 seconds
✔ OK py27 in 1 minute, 48.411 seconds

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to any/all clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* small updates to docstrings
* small updates to tests
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7bc6392
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7bc6392
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-zwei-pr
  • Commit ID: 7bc6392
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7bc6392
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4681b90
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4681b90
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4681b90
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-zwei-pr
  • Commit ID: 4681b90
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@metrizable metrizable merged commit 5233dfc into aws:zwei Jun 11, 2020
@metrizable metrizable deleted the require-framework-version-xgboost branch June 11, 2020 05:16
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
* add in-process mode for DJL server

* fix format

* add inference_spec as a member of DJL

* add the validations for model server

* fix typo

* fix test assertion

* add unit-testing

* have a common server for inprocess mode

* fix failing tests

* add support to torchserve

* fix tests to include torchserve servers

* use custom inference_spec code instead of HF pipelines

* fix tests for app.py

* fix unit test failure

* fix format

* use schema_builder for serialization and deserialization

* remove task field

* remove unused import
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
* add in-process mode for DJL server

* fix format

* add inference_spec as a member of DJL

* add the validations for model server

* fix typo

* fix test assertion

* add unit-testing

* have a common server for inprocess mode

* fix failing tests

* add support to torchserve

* fix tests to include torchserve servers

* use custom inference_spec code instead of HF pipelines

* fix tests for app.py

* fix unit test failure

* fix format

* use schema_builder for serialization and deserialization

* remove task field

* remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants