Skip to content

change: require framework_version, py_version for xgboost #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/xgboost/estimator.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def __init__(
on SageMaker. For convenience, this accepts other types for keys and values, but
``str()`` will be called to convert them before training.
py_version (str): Python version you want to use for executing your model
training code (default: 'py3'). One of 'py2' or 'py3'.
training code (default: 'py3').
image_name (str): If specified, the estimator will use this image for training and
hosting, instead of selecting the appropriate SageMaker official image
based on framework_version and py_version. It can be an ECR url or
Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/xgboost/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def __init__(
image (str): A Docker image URI (default: None). If not specified, a default image for
XGBoos will be used.
py_version (str): Python version you want to use for executing your model training code
(default: 'py2').
(default: 'py3').
framework_version (str): XGBoost version you want to use for executing your model
training code.
predictor_cls (callable[str, sagemaker.session.Session]): A function to call to create
Expand Down
2 changes: 1 addition & 1 deletion tests/integ/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
TUNING_DEFAULT_TIMEOUT_MINUTES = 20
TRANSFORM_DEFAULT_TIMEOUT_MINUTES = 20
AUTO_ML_DEFAULT_TIMEMOUT_MINUTES = 60
PYTHON_VERSION = "py" + str(sys.version_info.major)
PYTHON_VERSION = "py{}".format(sys.version_info.major)

# these regions have some p2 and p3 instances, but not enough for continuous testing
HOSTING_NO_P2_REGIONS = [
Expand Down
1 change: 1 addition & 0 deletions tests/integ/test_airflow_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ def test_tf_airflow_config_uploads_data_source_to_s3(sagemaker_session, cpu_inst


@pytest.mark.canary_quick
@pytest.mark.skipif(PYTHON_VERSION == "py2", reason="XGBoost container does not support Python 2.")
def test_xgboost_airflow_config_uploads_data_source_to_s3(sagemaker_session, cpu_instance_type):
with timeout(seconds=AIRFLOW_CONFIG_TIMEOUT_IN_SECONDS):
xgboost = XGBoost(
Expand Down
4 changes: 4 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ commands =
{env:IGNORE_COVERAGE:} coverage report --fail-under=86
extras = test

[testenv:py27]
setenv =
IGNORE_COVERAGE = true

[testenv:flake8]
basepython = python3
skipdist = true
Expand Down