Skip to content

breaking: require framework_version, py_version for sklearn #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

breaking: require framework_version, py_version for sklearn #1576

merged 1 commit into from
Jun 11, 2020

Conversation

metrizable
Copy link
Contributor

require framework_version and py_version for sklearn

Issue #, if available: #1465

Description of changes:

changes include:

  • framework_version, py_version required for framework SKLearn
  • framework_version, py_version required for framework SKLearnModel
  • py_version requires py3 or None, as py2 support dropped
  • image_name required if either framework_version or py_version None
  • unit and integ testing updates
  • doc updates

Testing done:

unit:

 % tox --parallel 3 tests/unit
✔ OK black-format in 11.287 seconds
✔ OK flake8 in 23.448 seconds
✔ OK twine in 13.898 seconds
✔ OK pylint in 35.064 seconds
✔ OK doc8 in 18.61 seconds
✔ OK py36 in 35.846 seconds
✔ OK sphinx in 1 minute, 26.284 seconds
✔ OK py37 in 36.384 seconds
✔ OK py27 in 1 minute, 50.325 seconds

integ:

% export IGNORE_COVERAGE=- ; tox -e py37 -- -s tests/integ/test_sklearn_train.py; unset IGNORE_COVERAGE
...
tests/integ/test_sklearn_train.py::test_training_with_additional_hyperparameters
...
Billable seconds: 71
PASSED
tests/integ/test_sklearn_train.py::test_attach_deploy SKIPPED
...

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to any/all clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@metrizable
breaking: require framework_version, py_version for sklearn
62545af 
* framework_version, py_version required for framework SKLearn
* framework_version, py_version required for framework SKLearnModel
* py_version requires py3 or None, as py2 support dropped
* image_name required if either framework_version or py_version None
* unit and integ testing updates
* doc updates
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 62545af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 62545af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-zwei-pr
  • Commit ID: 62545af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 62545af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

chuyang-deng
chuyang-deng suggested changes Jun 11, 2020
View reviewed changes
@metrizable metrizable merged commit 9977206 into aws:zwei Jun 11, 2020
@metrizable metrizable deleted the require-framework-version-sklearn branch June 11, 2020 16:37
pintaoz-aws added a commit that referenced this pull request Dec 4, 2024
@pintaoz-aws @benieric
@nargokul @pravali96
Single container local training (#1556)
5a37fc5 
* Base model trainer (#1521)

* Base model trainer

* flake8

* add testing notebook

* add param validation & set defaults

* Implement simple train method

* feature: support script mode with local train.sh (#1523)

* feature: support script mode with local train.sh

* Stop tracking train.sh and add it to .gitignore

* update message

* make dir if not exist

* fix docs

* fix: docstyle

* Address comments

* fix hyperparams

* Revert pydantic custom error

* pylint

* Image Spec refactoring and updates (#1525)

* Image Spec refactoring and updates

* Unit tests and update function for Image Spec

* Fix hugging face test

* Fix Tests

* Add unit tests for ModelTrainer (#1527)

* Add unit tests for ModelTrainer

* Flake8

* format

* Add example notebook (#1528)

* Add testing notebook

* format

* use smaller data

* remove large dataset

* update

* pylint

* flake8

* ignore docstyle in directories with test

* format

* format

* Add enviornment variable bootstrapping script (#1530)

* Add enviornment variables scripts

* format

* fix comment

* add docstrings

* fix comment

* feature: add utility function to capture local snapshot (#1524)

* local snapshot

* Update pip list command

* Remove function calls

* Address comments

* Address comments

* Support intelligent parameters (#1540)

* Support intelligent parameters

* fix codestyle

* Revert Image Spec (#1541)

* Cleanup ModelTrainer (#1542)

* General image builder (#1546)

* General image builder

* General image builder

* Fix codestyle

* Fix codestyle

* Move location

* Add warnings

* Add integ tests

* Fix integ test

* Fix integ test

* Fix region error

* Add region

* Latest Container Image (#1545)

* Latest Container Image

* Test Fixes

* Parameterized tests and some logic updates

* Test fixes

* Move to Image URI

* Fixes for unit test

* Fixes for unit test

* Fix codestyle error checks

* Cleanup ModelTrainer code (#1552)

* Single container local mode training

* Add wait argument

* Implement helper funtions

* Add helper functions

* Fix bugs

* Fix codestyle

* feat: add pre-processing and post-processing logic to inference_spec (#1560)

* add pre-processing and post-processing logic to inference_spec

* fix format

* make  accept_type and content_type optional

* remove accept_type and content_type from pre/post processing

* correct typo

* Fix test and codestyle

* Add Distributed Training Support Model Trainer (#1536)

* Add tests

* Add path to set Additional Settings in ModelTrainer (#1555)

* Added example notebook

* Fix codestyle

* Address comments

* resolve merge conflict

* Support multi container local training (#1576)

* Fix codestyle

* Mask Sensitive Env Logs in Container (#1568)

* Fix bug in script mode setup ModelTrainer (#1575)

* Support multi container local training

* Merge branch 'single_container_local_training' into multi_container_local_training

* Update unit tests

---------

Co-authored-by: Erick Benitez-Ramos <[email protected]>

* Remove LocalTrainingJob class

* Bypass pydantic check

* Add example

---------

Co-authored-by: Erick Benitez-Ramos <[email protected]>
Co-authored-by: Gokul Anantha Narayanan <[email protected]>
Co-authored-by: Pravali Uppugunduri <[email protected]>
pintaoz-aws added a commit that referenced this pull request Dec 4, 2024
@pintaoz-aws @benieric
@nargokul @pravali96
Single container local training (#1556)
cae3f81 
* Base model trainer (#1521)

* Base model trainer

* flake8

* add testing notebook

* add param validation & set defaults

* Implement simple train method

* feature: support script mode with local train.sh (#1523)

* feature: support script mode with local train.sh

* Stop tracking train.sh and add it to .gitignore

* update message

* make dir if not exist

* fix docs

* fix: docstyle

* Address comments

* fix hyperparams

* Revert pydantic custom error

* pylint

* Image Spec refactoring and updates (#1525)

* Image Spec refactoring and updates

* Unit tests and update function for Image Spec

* Fix hugging face test

* Fix Tests

* Add unit tests for ModelTrainer (#1527)

* Add unit tests for ModelTrainer

* Flake8

* format

* Add example notebook (#1528)

* Add testing notebook

* format

* use smaller data

* remove large dataset

* update

* pylint

* flake8

* ignore docstyle in directories with test

* format

* format

* Add enviornment variable bootstrapping script (#1530)

* Add enviornment variables scripts

* format

* fix comment

* add docstrings

* fix comment

* feature: add utility function to capture local snapshot (#1524)

* local snapshot

* Update pip list command

* Remove function calls

* Address comments

* Address comments

* Support intelligent parameters (#1540)

* Support intelligent parameters

* fix codestyle

* Revert Image Spec (#1541)

* Cleanup ModelTrainer (#1542)

* General image builder (#1546)

* General image builder

* General image builder

* Fix codestyle

* Fix codestyle

* Move location

* Add warnings

* Add integ tests

* Fix integ test

* Fix integ test

* Fix region error

* Add region

* Latest Container Image (#1545)

* Latest Container Image

* Test Fixes

* Parameterized tests and some logic updates

* Test fixes

* Move to Image URI

* Fixes for unit test

* Fixes for unit test

* Fix codestyle error checks

* Cleanup ModelTrainer code (#1552)

* Single container local mode training

* Add wait argument

* Implement helper funtions

* Add helper functions

* Fix bugs

* Fix codestyle

* feat: add pre-processing and post-processing logic to inference_spec (#1560)

* add pre-processing and post-processing logic to inference_spec

* fix format

* make  accept_type and content_type optional

* remove accept_type and content_type from pre/post processing

* correct typo

* Fix test and codestyle

* Add Distributed Training Support Model Trainer (#1536)

* Add tests

* Add path to set Additional Settings in ModelTrainer (#1555)

* Added example notebook

* Fix codestyle

* Address comments

* resolve merge conflict

* Support multi container local training (#1576)

* Fix codestyle

* Mask Sensitive Env Logs in Container (#1568)

* Fix bug in script mode setup ModelTrainer (#1575)

* Support multi container local training

* Merge branch 'single_container_local_training' into multi_container_local_training

* Update unit tests

---------

Co-authored-by: Erick Benitez-Ramos <[email protected]>

* Remove LocalTrainingJob class

* Bypass pydantic check

* Add example

---------

Co-authored-by: Erick Benitez-Ramos <[email protected]>
Co-authored-by: Gokul Anantha Narayanan <[email protected]>
Co-authored-by: Pravali Uppugunduri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuyang-deng chuyang-deng chuyang-deng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metrizable @sagemaker-bot @chuyang-deng