Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

[Dart] resync Dart .jade files, post-TS-RC5 #2077

Closed
10 of 14 tasks
chalin opened this issue Aug 10, 2016 · 2 comments
Closed
10 of 14 tasks

[Dart] resync Dart .jade files, post-TS-RC5 #2077

chalin opened this issue Aug 10, 2016 · 2 comments
Labels

Comments

@chalin
Copy link
Contributor

chalin commented Aug 10, 2016

Follow up to #2043.

chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 10, 2016
- Resync Dart QS prose with TS, post RC5.
- Delete cached QS jade file.
- Eliminate the stub file `styles.1.css` in favor of a `docregion` in
the main `styles.css`.

This commit requires a `gulp add-example-boilerplate`.
Contributes to angular#2077.
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 10, 2016
- Resync Dart QS prose with TS, post RC5.
- Added to-be-shared Jade `var` definitions to `_util-fns.jade`.
- Delete cached QS jade file.
- Eliminate the stub file `styles.1.css` in favor of a `docregion` in
the main `styles.css`.

This commit requires a `gulp add-example-boilerplate`.
Contributes to angular#2077.
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 10, 2016
- Resync Dart QS prose with TS, post RC5.
- Added to-be-shared Jade `var` definitions to `_util-fns.jade`.
- Delete cached QS jade file.
- Eliminate the stub file `styles.1.css` in favor of a `docregion` in
the main `styles.css`.

This commit requires a `gulp add-example-boilerplate`.
Contributes to angular#2077.
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 10, 2016
- Resync Dart QS prose with TS, post RC5.
- Added to-be-shared Jade `var` definitions to `_util-fns.jade`.
- Delete cached QS jade file.
- Eliminate the stub file `styles.1.css` in favor of a `docregion` in
the main `styles.css`.

This commit requires a `gulp add-example-boilerplate` after pulling it in.
Contributes to angular#2077.
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 10, 2016
kwalrath pushed a commit that referenced this issue Aug 10, 2016
* docs(quickstart): post-RC5 Dart resync

- Resync Dart QS prose with TS, post RC5.
- Added to-be-shared Jade `var` definitions to `_util-fns.jade`.
- Delete cached QS jade file.
- Eliminate the stub file `styles.1.css` in favor of a `docregion` in
the main `styles.css`.

This commit requires a `gulp add-example-boilerplate` after pulling it in.
Contributes to #2077.

* post-review edits
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 10, 2016
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 11, 2016
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 11, 2016
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 11, 2016
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 11, 2016
chalin added a commit to chalin/angular.io that referenced this issue Aug 11, 2016
kwalrath pushed a commit that referenced this issue Aug 11, 2016
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 11, 2016
Contributes to angular#2077.

TS-side changes include:
- Merged three versions of `app/app.module{,1,2}.ts` into a single file
and used docregions instead.
- Misnamed files:
  - `rxjs-operators.ts` -> `rxjs-extensions.ts`
  - `hero-search.service.html` -> `hero-search.component.html`
- Fixed BAD FILENAME error.

Lint reports no errors and toh-6 e2e tests pass.
kwalrath pushed a commit that referenced this issue Aug 12, 2016
* toh-6: trim spaces from cache file to simplify diff

* toh-6: copy latest over cache before editing latest

* docs(toh-6): post-RC5 Dart resync and TS fixes

Contributes to #2077.

TS-side changes include:
- Merged three versions of `app/app.module{,1,2}.ts` into a single file
and used docregions instead.
- Misnamed files:
  - `rxjs-operators.ts` -> `rxjs-extensions.ts`
  - `hero-search.service.html` -> `hero-search.component.html`
- Fixed BAD FILENAME error.

Lint reports no errors and toh-6 e2e tests pass.
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 14, 2016
**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**

This is preparatory work for angular#2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (angular#2018).
By the same token it contributed to a post-RC5 resync (angular#2077). Other
key changes:

Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.

TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.

Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 16, 2016
Contributes to angular#2077.

Suites passed:
 - public/docs/_examples/template-syntax/dart
 - public/docs/_examples/template-syntax/ts
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 17, 2016
**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**

This is preparatory work for angular#2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (angular#2018).
By the same token it contributed to a post-RC5 resync (angular#2077). Other
key changes:

Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.

TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.

Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).
kwalrath pushed a commit that referenced this issue Aug 17, 2016
* docs(toh-5): review and update/resync Dart

**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**

This is preparatory work for #2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (#2018).
By the same token it contributed to a post-RC5 resync (#2077). Other
key changes:

Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.

TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.

Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).

* docs(toh-5): edits after doing tutorial

- Some adjustments following actually doing the tutorial. In some cases code shown (e.g. this is what file foo should look like now) didn't match what the user would have. E.g., lingering @input on the hero property.
- Fixed some lingering deprecated-router prose elements on TS side (e.g., still referring to a route by the old string names like `HeroDetail`).
- Added extra step to `app.component.ts` creation rather than having a critical-call-out later on.
- Reorder some prose for better harmony between TS and Dart prose (also improves the flow).
- Moved the `styleUrls` call-out to the point of first use.

* post-review changes

* more post-review changes

* toh-6 cache update
wardbell pushed a commit that referenced this issue Aug 17, 2016
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 18, 2016
- TS prose: removed mention of `routerOnActivate` which no longer
exists in the new router.
- TS improvements to the sample code have also been propagated to the
Dart sample.

Contributes to angular#2077.
E2E tests pass now.
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 19, 2016
- TS prose: removed mention of `routerOnActivate` which no longer
exists in the new router.
- TS improvements to the sample code have also been propagated to the
Dart sample.

Contributes to angular#2077.
E2E tests pass now.
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 19, 2016
- TS prose: removed mention of `routerOnActivate` which no longer
exists in the new router.
- TS improvements to the sample code have also been propagated to the
Dart sample.

Contributes to angular#2077.
E2E tests pass now.
kwalrath pushed a commit that referenced this issue Aug 19, 2016
* lifecycle-hooks: copy latest to cache

* docs(lifecycle-hooks): post-RC5 Dart resync

- TS prose: removed mention of `routerOnActivate` which no longer
exists in the new router.
- TS improvements to the sample code have also been propagated to the
Dart sample.

Contributes to #2077.
E2E tests pass now.

* post-review updates
@chalin chalin added the dart label Dec 16, 2016
@Foxandxss
Copy link
Member

Closing this, if that is a mistake, we reopen.

@chalin
Copy link
Contributor Author

chalin commented Feb 13, 2017

Yes, closing it now is fine. I've migrated the issue to https://github.com/dart-lang/site-webdev/issues/368.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants