This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-6): add hero search to Dart; minor edits to TS #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -135,21 +135,21 @@ block get-heroes-details | |||
|
|
|||
| For *now* we get back on familiar ground by immediately by | |||
| converting that `Observable` to a `Promise` using the `toPromise` operator. | |||
| +makeExample('toh-6/ts/app/hero.service.ts', 'to-promise')(format=".") | |||
| +makeExcerpt('app/hero.service.ts', 'to-promise') | |||
There was a problem hiding this comment.
I'm not crazy about adding the big blue title to all the one-line examples. It gives the source of the code more weight than the actual code.
There was a problem hiding this comment.
Oups, didn't mean for that to happen. I forgot that the convention for including/excluding a title with makeExcerpt is reversed as compared to makeExample. Fixed all of excerpts that originally did not have a title.
|
@kwalrath : updates pushed. |
| :marked | ||
| Fortunately, there are stream transformers that will help us reduce the request flow. | ||
| We'll make fewer calls to the `HeroSearchService` and still get timely results. Here's how: | ||
| starting from the underlying stream of search terms we |
There was a problem hiding this comment.
This line looks weird and ungrammatical. Can we just delete it?
|
Some minor issues, but otherwise looks great! |
|
LGTM |
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Aug 14, 2016
**NOTE: run `gulp add-example-boilerplate` after pulling in the commit.** This is preparatory work for angular#2035. As part of the the chapter review, the Dart .jade was enhanced to use Jade extends (angular#2018). By the same token it contributed to a post-RC5 resync (angular#2077). Other key changes: Dart and TS code: - Eliminated `styles.1.css` in favor of docregions in `styles.css`. - `docregion` tags renamed in a few places. - **No other code changes**. TS prose - Fixed: misnamed variable `routing` -> `appRoutes`. - All other changes are **minor copy edits**, or changes to support Dart via Jade extends. Diff of generated HTML for TS chapter was inspected to ensure only minor copy edits prevailed (i.e., that the support for Jade extends had no impact on the generated HTML).
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Aug 17, 2016
**NOTE: run `gulp add-example-boilerplate` after pulling in the commit.** This is preparatory work for angular#2035. As part of the the chapter review, the Dart .jade was enhanced to use Jade extends (angular#2018). By the same token it contributed to a post-RC5 resync (angular#2077). Other key changes: Dart and TS code: - Eliminated `styles.1.css` in favor of docregions in `styles.css`. - `docregion` tags renamed in a few places. - **No other code changes**. TS prose - Fixed: misnamed variable `routing` -> `appRoutes`. - All other changes are **minor copy edits**, or changes to support Dart via Jade extends. Diff of generated HTML for TS chapter was inspected to ensure only minor copy edits prevailed (i.e., that the support for Jade extends had no impact on the generated HTML).
kwalrath
pushed a commit
that referenced
this pull request
Aug 17, 2016
* docs(toh-5): review and update/resync Dart **NOTE: run `gulp add-example-boilerplate` after pulling in the commit.** This is preparatory work for #2035. As part of the the chapter review, the Dart .jade was enhanced to use Jade extends (#2018). By the same token it contributed to a post-RC5 resync (#2077). Other key changes: Dart and TS code: - Eliminated `styles.1.css` in favor of docregions in `styles.css`. - `docregion` tags renamed in a few places. - **No other code changes**. TS prose - Fixed: misnamed variable `routing` -> `appRoutes`. - All other changes are **minor copy edits**, or changes to support Dart via Jade extends. Diff of generated HTML for TS chapter was inspected to ensure only minor copy edits prevailed (i.e., that the support for Jade extends had no impact on the generated HTML). * docs(toh-5): edits after doing tutorial - Some adjustments following actually doing the tutorial. In some cases code shown (e.g. this is what file foo should look like now) didn't match what the user would have. E.g., lingering @input on the hero property. - Fixed some lingering deprecated-router prose elements on TS side (e.g., still referring to a route by the old string names like `HeroDetail`). - Added extra step to `app.component.ts` creation rather than having a critical-call-out later on. - Reorder some prose for better harmony between TS and Dart prose (also improves the flow). - Moved the `styleUrls` call-out to the point of first use. * post-review changes * more post-review changes * toh-6 cache update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS minor edits:
Dart update:
Note: in anticipation of #1751,
sample.csshas been eliminated from the Dart example.