Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

[Dart] add router guide #2035

Closed
3 tasks
chalin opened this issue Aug 5, 2016 · 1 comment
Closed
3 tasks

[Dart] add router guide #2035

chalin opened this issue Aug 5, 2016 · 1 comment
Labels

Comments

@chalin
Copy link
Contributor

chalin commented Aug 5, 2016

Follow-up work to #2026.

  • Create chapter JADE.
  • Create chapter example source.
  • setup example under angular-examples.

cc @kwalrath

@kwalrath kwalrath added the dart label Aug 5, 2016
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 14, 2016
**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**

This is preparatory work for angular#2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (angular#2018).
By the same token it contributed to a post-RC5 resync (angular#2077). Other
key changes:

Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.

TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.

Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).
chalin added a commit to IdeaBlade/angular.io that referenced this issue Aug 17, 2016
**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**

This is preparatory work for angular#2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (angular#2018).
By the same token it contributed to a post-RC5 resync (angular#2077). Other
key changes:

Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.

TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.

Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).
kwalrath pushed a commit that referenced this issue Aug 17, 2016
* docs(toh-5): review and update/resync Dart

**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**

This is preparatory work for #2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (#2018).
By the same token it contributed to a post-RC5 resync (#2077). Other
key changes:

Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.

TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.

Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).

* docs(toh-5): edits after doing tutorial

- Some adjustments following actually doing the tutorial. In some cases code shown (e.g. this is what file foo should look like now) didn't match what the user would have. E.g., lingering @input on the hero property.
- Fixed some lingering deprecated-router prose elements on TS side (e.g., still referring to a route by the old string names like `HeroDetail`).
- Added extra step to `app.component.ts` creation rather than having a critical-call-out later on.
- Reorder some prose for better harmony between TS and Dart prose (also improves the flow).
- Moved the `styleUrls` call-out to the point of first use.

* post-review changes

* more post-review changes

* toh-6 cache update
@chalin
Copy link
Contributor Author

chalin commented Dec 16, 2016

@chalin chalin closed this as completed Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants