This repository was archived by the owner on Dec 4, 2017. It is now read-only.
[Dart] ToH-6 updates following addition of Observables section on TS side #1924
Labels
Comments
|
@chalin, please handle this. (I can't assign to you.) |
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this issue
Jul 31, 2016
Changes: - Drop `asObservable()` since it is deprecated in RxJS 5 (see the [migration guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat ors-renamed-or-removed)). - Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At best it is interpreted as a regex op that serves no purpose, at worst, it gets interpreted as a space (cf. [HTML 4.01 section 17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4) ). - Replace the generic term "term" by "pattern" since the serach string is actually a search pattern (regex). - Rename `searchSubject` to `searchPatterns` (or maybe it should be `searchPattern$`) since subjects are just observables that can have data injected into them. - Other minor tweak to prose. This work is in preparation for angular#1924. Note: toh-6 tests pass.
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this issue
Jul 31, 2016
Changes: - Drop `asObservable()` since it is deprecated in RxJS 5 (see the [migration guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat ors-renamed-or-removed)). - Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At best it is interpreted as a regex op that serves no purpose, at worst, it gets interpreted as a space (cf. [HTML 4.01 section 17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4) ). - Replace the generic term "term" by "pattern" since the serach string is actually a search pattern (regex). - Rename `searchSubject` to `searchPatterns` (or maybe it should be `searchPattern$`) since subjects are just observables that can have data injected into them. - Other minor tweak to prose. This work is in preparation for angular#1924. Note: toh-6 tests pass.
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this issue
Aug 1, 2016
Changes: - Drop `asObservable()` since it is deprecated in RxJS 5 (see the [migration guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat ors-renamed-or-removed)). - Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At best it is interpreted as a regex op that serves no purpose, at worst, it gets interpreted as a space (cf. [HTML 4.01 section 17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4) ). - Replace the generic term "term" by "pattern" since the serach string is actually a search pattern (regex). - Rename `searchSubject` to `searchPatterns` (or maybe it should be `searchPattern$`) since subjects are just observables that can have data injected into them. - Other minor tweak to prose. This work is in preparation for angular#1924. Note: toh-6 tests pass.
wardbell
pushed a commit
that referenced
this issue
Aug 1, 2016
closes #2008 Changes: - Drop `asObservable()` since it is deprecated in RxJS 5 (see the [migration guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat ors-renamed-or-removed)). - Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At best it is interpreted as a regex op that serves no purpose, at worst, it gets interpreted as a space (cf. [HTML 4.01 section 17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4) ). - Rename `searchSubject` to `searchTerms` - Other minor tweaks to prose. This work is in preparation for #1924. Note: toh-6 tests pass.
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this issue
Aug 2, 2016
kwalrath
pushed a commit
that referenced
this issue
Aug 2, 2016
* docs(toh-6/dart): add hero search Fixes #1924. * docs(toh-6/ts): minor updates * post-review updates * post-review updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Dart follow-up to #1528.
The text was updated successfully, but these errors were encountered: