This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-6): search query fixes #2008
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-toh-6-search-query-fixes-0731
branch
from
0869b89 to
6fe2e4e
Compare
|
Honestly, I prefer the "term" term. |
|
I like these changes ... except the word "pattern". Although you are technically correct that it is a pattern, semantically it's about search terms. I can roll with this if Patrice doesn't mind sticking with that. I'm happy to fix as i merge or he can update. I'm standing by. |
|
I don't mind sticking with "term". I'll update |
Changes: - Drop `asObservable()` since it is deprecated in RxJS 5 (see the [migration guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat ors-renamed-or-removed)). - Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At best it is interpreted as a regex op that serves no purpose, at worst, it gets interpreted as a space (cf. [HTML 4.01 section 17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4) ). - Replace the generic term "term" by "pattern" since the serach string is actually a search pattern (regex). - Rename `searchSubject` to `searchPatterns` (or maybe it should be `searchPattern$`) since subjects are just observables that can have data injected into them. - Other minor tweak to prose. This work is in preparation for angular#1924. Note: toh-6 tests pass.
chalin
force-pushed
the
chalin-toh-6-search-query-fixes-0731
branch
from
6fe2e4e to
fd0882d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
asObservable()since it is deprecated in RxJS 5 (see the migration guide).+from hero search query URL:app/heroes/?name=${term}+. At best it is interpreted as a regex op that serves no purpose, at worst, it gets interpreted as a space (cf. HTML 4.01 section 17.13.4).searchSubjecttosearchPatterns(or maybe it should besearchPattern$) since subjects are just observables that can have data injected into them.This work is in preparation for #1924.
Note: toh-6 tests pass.