docs(toh-6): search query fixes

Changes:
- Drop `asObservable()` since it is deprecated in RxJS 5 (see the
[migration
guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat
ors-renamed-or-removed)).
- Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At
best it is interpreted as a regex op that serves no purpose, at worst,
it gets interpreted as a space (cf. [HTML 4.01 section
17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4)
).
- Replace the generic term "term" by "pattern" since the serach string
is actually a search pattern (regex).
- Rename `searchSubject` to `searchPatterns` (or maybe it should be
`searchPattern$`) since subjects are just observables that can have
data injected into them.
- Other minor tweak to prose.

This work is in preparation for #1924.

Note: toh-6 tests pass.

Author: chalin

public/docs/_examples/toh-6/ts/app/dashboard.component.html

@@ -1,13 +1,10 @@
 <!-- #docregion -->
 <h3>Top Heroes</h3>
 <div class="grid grid-pad">
-<!-- #docregion click -->
   <div *ngFor="let hero of heroes" (click)="gotoDetail(hero)" class="col-1-4">
-<!-- #enddocregion click -->
     <div class="module hero">
       <h4>{{hero.name}}</h4>
     </div>
   </div>
 </div>
 <hero-search></hero-search>
-

public/docs/_examples/toh-6/ts/app/hero-search.component.ts

@@ -17,33 +17,31 @@ export class HeroSearchComponent implements OnInit {
   // #docregion search
   heroes: Observable<Hero[]>;
   // #enddocregion search
-  // #docregion searchSubject
-  searchSubject = new Subject<string>();
-  // #enddocregion searchSubject
+  // #docregion searchPatterns
+  searchPatterns = new Subject<string>();
+  // #enddocregion searchPatterns
 
   constructor(
     private heroSearchService: HeroSearchService,
     private router: Router) {}
-  // #docregion searchSubject
+  // #docregion searchPatterns
 
-  // Push a search term into the observable stream.
-  search(term: string) { this.searchSubject.next(term); }
-  // #enddocregion searchSubject
+  // Push a search pattern into the observable stream.
+  search(pattern: string) { this.searchPatterns.next(pattern); }
+  // #enddocregion searchPatterns
   // #docregion search
 
   ngOnInit() {
-    this.heroes = this.searchSubject
-      .asObservable()           // cast as Observable
+    this.heroes = this.searchPatterns
       .debounceTime(300)        // wait for 300ms pause in events
-      .distinctUntilChanged()   // ignore if next search term is same as previous
-      .switchMap(term => term   // switch to new observable each time
+      .distinctUntilChanged()   // ignore if next search pattern is same as previous
+      .switchMap(pattern => pattern   // switch to new observable each time
         // return the http search observable
-        ? this.heroSearchService.search(term)
-        // or the observable of empty heroes if no search term
+        ? this.heroSearchService.search(pattern)
+        // or the observable of empty heroes if no search pattern
         : Observable.of<Hero[]>([]))
-
       .catch(error => {
-        // Todo: real error handling
+        // TODO: real error handling
         console.log(error);
         return Observable.of<Hero[]>([]);
       });

public/docs/_examples/toh-6/ts/app/hero-search.service.ts

@@ -9,11 +9,9 @@ export class HeroSearchService {
 
   constructor(private http: Http) {}
 
-  // #docregion observable-search
-  search(term: string) {
+  search(pattern: string) {
     return this.http
-               .get(`app/heroes/?name=${term}+`)
+               .get(`app/heroes/?name=${pattern}`)
                .map((r: Response) => r.json().data as Hero[]);
   }
-  // #enddocregion observable-search
 }

public/docs/ts/latest/tutorial/toh-pt6.jade

@@ -419,11 +419,11 @@ block observables-section
     Time to create the `HeroSearchComponent` class and metadata.
   +makeExample('toh-6/ts/app/hero-search.component.ts', null,'hero-search.component.ts')
   :marked
-    Focus on the `searchSubject`.
-  +makeExample('toh-6/ts/app/hero-search.component.ts', 'searchSubject')(format=".")
+    Focus on the `searchPatterns`.
+  +makeExample('toh-6/ts/app/hero-search.component.ts', 'searchPatterns')(format=".")
   :marked
     A `Subject` is a producer of an _observable_ event stream. 
-    This `searchSubject` produces an `Observable` of strings, the filter criteria for the name search.
+    This `searchPatterns` produces an `Observable` of strings, the filter criteria for the name search.
 
     Each call to `search` puts a new string into this subject's _observable_ stream by calling `next`.
 
@@ -495,11 +495,11 @@ block observables-section
   +makeExample('toh-6/ts/app/app.component.ts', 'rxjs-extensions', 'app/app.component.ts')(format=".")
 
   :marked
-    ### Adding the search component to the dashboard
+    ### Add the search component to the dashboard
 
-    We add the `HeroSearchComponent` to the bottom of the `DashboardComponent` template.
+    We add the hero search HTML element to the bottom of the `DashboardComponent` template.
 
-  +makeExample('toh-6/ts/app/dashboard.component.html', null, 'dashboard.component.html')
+  +makeExample('app/dashboard.component.html')
 
   :marked
     And finally, we import the `HeroSearchComponent` and add it to the `directives` array.