docs(add observables to TOH http) #1528
Conversation
thelgevold
force-pushed
the
toh-http-observables
branch
from
e11c346 to
34b17f7
Compare
thelgevold
changed the title
|
@wardbell |
thelgevold
force-pushed
the
toh-http-observables
branch
from
34b17f7 to
cbc74b5
Compare
|
I resolved merge conflicts from other PRs. This one is ready to go |
| @@ -110,8 +110,8 @@ code-example(format="." language="bash"). | |||
|
|
|||
| The Angular `http.get` returns an RxJS `Observable`. | |||
| *Observables* are a powerful way to manage asynchronous data flows. | |||
| We'll learn about `Observables` *later*. | |||
|
|
|||
| We'll learn about `Observables` in the next chapter. | |||
There was a problem hiding this comment.
Change "chapter" to "section".
|
@chalin Good call. I agree |
thelgevold
force-pushed
the
toh-http-observables
branch
from
cbc74b5 to
ce37f0a
Compare
|
Changed from chapter to section based on feedback from @chalin |
thelgevold
force-pushed
the
toh-http-observables
branch
from
ce37f0a to
1024f9c
Compare
|
Rebased to latest master |
thelgevold
force-pushed
the
toh-http-observables
branch
3 times, most recently
from
b6ef9c6 to
d9b8440
Compare
thelgevold
force-pushed
the
toh-http-observables
branch
from
d9b8440 to
c812ee6
Compare
|
Rebased to latest master |
|
@wardbell, @Foxandxss : I think that it would be nice if this were merged before the next wave(s) of changes hit the ToH. It is a well contained addition that would nicely round up the http toh chapter. (Btw, we should probably mark parts of the server-communication chapter as outdated, or just trim them out, because this ToH chapter will have outpaced it!) |
|
Will review soon! |
e2e prose tweaks d d d section lint jade space update remove r test tweak tweak
wardbell
force-pushed
the
toh-http-observables
branch
from
c812ee6 to
a44412d
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
wardbell
force-pushed
the
toh-http-observables
branch
from
a44412d to
d623425
Compare
|
I made a bunch of clarifying edits in a separate commit. Ready to squash and merge |
@wardbell @johnpapa
This PR contains my addition of Observables to the TOH Http chapter