You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changes:
- Drop `asObservable()` since it is deprecated in RxJS 5 (see the
[migration
guide](https://github.com/ReactiveX/RxJS/blob/master/MIGRATION.md#operat
ors-renamed-or-removed)).
- Drop `+` from hero search query URL: `app/heroes/?name=${term}+`. At
best it is interpreted as a regex op that serves no purpose, at worst,
it gets interpreted as a space (cf. [HTML 4.01 section
17.13.4](https://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4)
).
- Replace the generic term "term" by "pattern" since the serach string
is actually a search pattern (regex).
- Rename `searchSubject` to `searchPatterns` (or maybe it should be
`searchPattern$`) since subjects are just observables that can have
data injected into them.
- Other minor tweak to prose.
This work is in preparation for angular#1924.
Note: toh-6 tests pass.
0 commit comments