This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-6): post-RC5 Dart resync and TS fixes #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to angular#2077. TS-side changes include: - Merged three versions of `app/app.module{,1,2}.ts` into a single file and used docregions instead. - Misnamed files: - `rxjs-operators.ts` -> `rxjs-extensions.ts` - `hero-search.service.html` -> `hero-search.component.html` - Fixed BAD FILENAME error. Lint reports no errors and toh-6 e2e tests pass.
|
@wardbell @Foxandxss: I'm not to sure who should review this, but given that @brandonroberts was the last to edit it, I'm including his name. @kwalrath : to see the diff between the old cached copy and the latest, look at the second commit. Note that in the final commit the cached and latest copies are the same (as they should be). All: as usual, it is best to view diffs by ignoring whitespace. |
|
LGTM. I compared the old & new Dart versions side-by-side, and the few diffs I noticed were improvements. Ditto for the old & new TypeScript versions. |
|
LGTM too |
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2077.
TS-side changes include:
app/app.module{,1,2}.tsinto a single file and used docregions instead.rxjs-operators.ts->rxjs-extensions.tshero-search.service.html->hero-search.component.htmlLint reports no errors and toh-6 e2e tests pass.