This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(quickstart): post-RC5 Dart resync #2078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Foxandxss @wardbell @kwalrath : as usual, it is best to view the diff while ignoring whitespace. |
14 tasks
chalin
force-pushed
the
chalin-dart-qs-rc5-resync-0810
branch
2 times, most recently
from
c06edbb to
a0576fa
Compare
- Resync Dart QS prose with TS, post RC5. - Added to-be-shared Jade `var` definitions to `_util-fns.jade`. - Delete cached QS jade file. - Eliminate the stub file `styles.1.css` in favor of a `docregion` in the main `styles.css`. This commit requires a `gulp add-example-boilerplate` after pulling it in. Contributes to angular#2077.
chalin
force-pushed
the
chalin-dart-qs-rc5-resync-0810
branch
from
2440846 to
bc83a75
Compare
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Aug 10, 2016
Contributes to angular#2077. Depends on angular#2078.
|
Comparing http://localhost:3000/docs/dart/latest/quickstart.html & https://angular.io/docs/dart/latest/quickstart.html side-by-side, I see an extra paragraph in the new one (the circled
|
|
Aside from that one thing, which you could fix later, LGTM. |
|
Yes, I had chosen to leave it out earlier, but since it is actually a target (#my-app), I figured that it made sense to include the "heading". |
chalin
force-pushed
the
chalin-dart-qs-rc5-resync-0810
branch
from
f43c0ba to
f4e6f5c
Compare
|
Merging now... |
|
For the record, the |
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Aug 10, 2016
Contributes to angular#2077. Depends on angular#2078.
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Aug 11, 2016
Contributes to angular#2077. Depends on angular#2078.
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Aug 11, 2016
Contributes to angular#2077. Depends on angular#2078.
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Aug 11, 2016
Contributes to angular#2077. Depends on angular#2078.
chalin
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Aug 11, 2016
Contributes to angular#2077. Depends on angular#2078.
kwalrath
pushed a commit
that referenced
this pull request
Aug 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vardefinitions to_util-fns.jade.styles.1.cssin favor of adocregionin the mainstyles.css.This commit requires a
gulp add-example-boilerplateafter pulling it in.Contributes to #2077.