removing assert statements #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jposada202020 Didn't see your original mention. Do you want to re-open? It generally looks OK. |
|
Yes :) no problem did not want to bother you again |
|
No worries. Feel free to ping me again. Totally my bad, not the best at catching GH mentions. :( |
caternuson
requested changes
May 23, 2021
|
Thanks for reviewing @caternuson Will do according to suggestions. |
|
@caternuson please review. Thanks :) |
caternuson
approved these changes
May 25, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 1, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#23 from jposada202020/improving_docs > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#22 from caternuson/iss21 Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.6 from 1.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#17 from jposada202020/correcting_returning_units > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.10 from 3.5.9: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#132 from mikejc58/wait_spi_char > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.3.7 from 3.3.6: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#36 from jvalrog/fix-servo-example > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#21 from jposada202020/changing_assertions > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.5.0 from 0.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#35 from jposada202020/adding_example_docs_improvement > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.10.1 from 1.10.0: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#34 from bjnhur/master > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.5.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#47 from adafruit/linting > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.9.3 from 1.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#39 from adafruit/linting > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#37 from jposada202020/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#18 from adafruit/linting > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.0.1 from 5.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_HID#69 from jfurcean/fix-led-example > Merge pull request adafruit/Adafruit_CircuitPython_HID#70 from FoamyGuy/adding_brightness_codes > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 2.2.0 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#31 from jposada202020/progressbar_accelerometer > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#30 from alimustafashah/master > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #20 . @caternuson Could you test this, Flying blind here do not have the hardware. I did some tests with the asserts vs the ifs in the REPL, but do not like to change code without testing. Thanks :)