Skip to content

Change asserts to exceptions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caternuson opened this issue Mar 31, 2021 · 5 comments
Closed

Change asserts to exceptions #20

caternuson opened this issue Mar 31, 2021 · 5 comments
Labels
good first issue Good for newcomers

Comments

@caternuson
Copy link

Not urgent. Just noticed this lib is still using asserts.
https://circuitpython.readthedocs.io/en/latest/docs/design_guide.html#exceptions-and-asserts

@jposada202020
Copy link
Contributor

@caternuson just for my info, what is the goal here, use exceptions instead of assert n the library?. thanks :)

@caternuson
Copy link
Author

Yep. See linked design guide info. Other CP libs could also be good reference. In general, this is a trivial change. I'll add a good first issue tag also FWIW.

@caternuson caternuson added the good first issue Good for newcomers label Apr 24, 2021
@jposada202020
Copy link
Contributor

will do, thanks :)

@jposada202020
Copy link
Contributor

solved by #21

@caternuson
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants