Skip to content

check recv size #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 27, 2021
Merged

check recv size #34

merged 10 commits into from
May 27, 2021

Conversation

bjnhur
Copy link
Contributor

@bjnhur bjnhur commented Apr 11, 2021

I saw the message from your example as follows.

  • Opening W5k Socket, protocol=33
    socket connected
    Socket read 0
  • socket_available called with protocol 33
    b''
    PHY Status: bytearray(b'\xbf')
    *** Disconnecting socket #0
    *** Closing socket #0

connect -> zero byte recv -> disconnect.
So, I can't test ECHO data.
How about adding check code that recv size is not zero?

gamblor21
gamblor21 reviewed Apr 11, 2021
View reviewed changes
@gamblor21
Copy link
Member

Looked the code over but could not test it as I don't have the hardware.

brentru
brentru requested changes Apr 12, 2021
View reviewed changes
@bjnhur bjnhur requested a review from brentru April 14, 2021 06:38
brentru
brentru requested changes Apr 14, 2021
View reviewed changes
@brentru
Copy link
Member

brentru commented Apr 16, 2021

@bjnhur The most recent commit is failing on Black formatting: (https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k/pull/34/checks?check_run_id=2350143393#step:11:30).

Please read thru https://learn.adafruit.com/improve-your-code-with-pylint and make the required changes for this PR to pass, thank you. Feel free to ask me any questions you have.

@bjnhur bjnhur requested a review from brentru April 21, 2021 23:49
@brentru
Copy link
Member

brentru commented May 6, 2021

@bjnhur Could you resolve the conflicts, then I'll test? Thanks

@jposada202020
Copy link

@brentru Hello, I think this PR is ready to review, could you take a look to see if this is ok? thanks.

@brentru
Copy link
Member

brentru commented May 26, 2021

@jposada202020 I'll test this tomorrow, added to my TODOs.

@brentru brentru merged commit 847070e into adafruit:master May 27, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 1, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@8da89ce)
a7dc294 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#23 from jposada202020/improving_docs
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#22 from caternuson/iss21

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#17 from jposada202020/correcting_returning_units
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.10 from 3.5.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#132 from mikejc58/wait_spi_char
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.3.7 from 3.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#36 from jvalrog/fix-servo-example
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.2.8 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#21 from jposada202020/changing_assertions
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.5.0 from 0.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#35 from jposada202020/adding_example_docs_improvement
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.10.1 from 1.10.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#34 from bjnhur/master
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.5.1 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#47 from adafruit/linting
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.9.3 from 1.9.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#39 from adafruit/linting
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#37 from jposada202020/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#18 from adafruit/linting
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.0.1 from 5.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#69 from jfurcean/fix-led-example
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#70 from FoamyGuy/adding_brightness_codes
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 2.2.0 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#31 from jposada202020/progressbar_accelerometer
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#30 from alimustafashah/master
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 4, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@8539627)
d683fe6 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.8.4 from 1.8.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#69 from jfurcean/add-rotaryio-docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.11.5 from 2.11.4:
  > Empty commit - related to main switch
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.10.2 from 1.10.1:
  > Moved default branch to main
  < Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#34 from bjnhur/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#1 from jposada202020/improving_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#16 from caternuson/slider

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Simple_Text_Display
evaherrada added a commit that referenced this pull request Jun 7, 2021
@evaherrada
Merge pull request #38 from bjnhur/master
d50fe38 
Recreating #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada left review comments

@gamblor21 gamblor21 gamblor21 left review comments

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjnhur @gamblor21 @brentru @jposada202020 @ladyada