Skip to content

Update to new build process and turn on lint. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 5, 2018
Merged

Update to new build process and turn on lint. #1

merged 6 commits into from
Jan 5, 2018

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Dec 7, 2017

No description provided.

@tannewt tannewt requested a review from a team December 7, 2017 19:54
dhalbert
dhalbert reviewed Dec 7, 2017
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @deshipu would like to review also. Added him as as reviewer.

adafruit_ht16k33/ht16k33.py
@@ -24,6 +51,7 @@ def _write_cmd(self, byte):
self.i2c_device.write(self._temp)

def blink_rate(self, rate=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a get/set property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I filed a separate issue for it: #2

adafruit_ht16k33/ht16k33.py Outdated
@@ -32,19 +60,22 @@ def blink_rate(self, rate=None):
_HT16K33_BLINK_DISPLAYON | rate << 1)

def brightness(self, brightness):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a get/set property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2

@tannewt
Copy link
Member Author

tannewt commented Dec 7, 2017

This is for adafruit/circuitpython#475

deshipu
deshipu suggested changes Dec 7, 2017
View reviewed changes
README.rst Outdated

Usage Example
=============
Using it is super simple. Simply import the `cpx` variable from the module
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpx variable?

adafruit_ht16k33/index.rst Outdated
.. automodule:: adafruit_ht16k33.matrix
:members:

`segments` - Segments display such as those on alarm clocks
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Segment displays

conf.py
# General information about the project.
project = u'Adafruit HT16K33 Library'
copyright = u'2016 Radomir Dopieralski'
author = u'Radomir Dopieralski'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the author of this library, or I must have been very drunk and don't remember it.

@deshipu
Copy link

deshipu commented Jan 5, 2018

Tested for the 14-seg display, the segments.py example works after commenting out display = segments.Seg7x4(i2c) and uncommenting #display = segments.Seg14x4(i2c).

@kattni kattni merged commit d62811d into adafruit:master Jan 5, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 10, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a1344cd)
f17cd41 
Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 1.0.0 from 0.8.0:
  > use struct when available, list comp instead of map() (adafruit/Adafruit_CircuitPython_FXAS21002C#2)

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 1.0.0 from 0.8.0:
  > use struct when available, change map() to list comp (adafruit/Adafruit_CircuitPython_FXOS8700#4)

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.0.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#1 from tannewt/lint

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.1.0 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#21 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.0.0 from 2.0.1:
  > Fix up ReadTheDocs. (adafruit/Adafruit_CircuitPython_PCA9685#9)
  > Huge refactor, switch to PWMOut compatible API. (adafruit/Adafruit_CircuitPython_PCA9685#8)

Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.1.0 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SD#5 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.2.0 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#8 from dhalbert/master
  > add bouncing ball example (adafruit/Adafruit_CircuitPython_SSD1306#6)

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.0.1 from 1.0.0:
  > Changes to the tone function (adafruit/Adafruit_CircuitPython_SimpleIO#24)
  > Make lint happy
  > handle reversed range on output
caternuson pushed a commit that referenced this pull request May 25, 2018
@elmwoodelec
Merge pull request #1 from elmwoodelec/elmwoodelec-patch-1
19c3403 
Update matrix.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert left review comments

@deshipu deshipu deshipu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tannewt @deshipu @dhalbert @kattni